refactor: Decouple the data deletion controller

[Gudahtt]

Description

The DataDeletionController has been decoupled from the MetaMetricsController by updating the constructor parameters to expect just a function for getting the MetaMetrics ID, rather than the entire MetaMetricsController state. This vastly simplifies the API surface, making it easier to audit and test. It also prevents the DataDeletionController from having the capability to make changes to the MetaMetricsController state.

Related issues

This is an improvement for #24503

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (d15ca11) to head (d15ca11).

❗ Current head d15ca11 differs from pull request most recent head 3e61f0b

Please upload reports for the commit 3e61f0b to get more accurate results.

Additional details and impacted files

@@                         Coverage Diff                         @@
##           delete-metametrics-data-controller   #24870   +/-   ##
===================================================================
  Coverage                               65.74%   65.74%           
===================================================================
  Files                                    1368     1368           
  Lines                                   54335    54335           
  Branches                                14124    14124           
===================================================================
  Hits                                    35722    35722           
  Misses                                  18613    18613           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [c90863b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (400 ± 370 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	171	100	25	12
		domContentLoaded	8	37	14	8	4
		load	54	2411	400	770	370
		domInteractive	8	37	14	8	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 7.26 KiB (0.21%)
• ui: 0 Bytes (0.00%)
• common: -388 Bytes (-0.01%)