-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create a story for TokenCurrencyDisplay component #25278
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Try rebasing to see if it resolves the failing tests. The failures are not caused by this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging with develop
branch should resolve this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Introduced a Storybook story for the TokenCurrencyDisplay
component to enable isolated UI testing and development.
- Added
ui/components/ui/token-currency-display/token-currency-display.stories.tsx
to define the Storybook story. - Configured the story with metadata, including title and argument types.
- Created a template for rendering the component with various props.
- Set initial arguments for
className
,transactionData
,token
, andprefix
in the default story instance.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Closing in favor of #26172 can't get Devin to reset soft and hard push to fix these tests |
Description
This PR introduces a Storybook story for the TokenCurrencyDisplay component to facilitate isolated UI testing and development.
Related issues
N/A
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Devin Run