Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for TokenCurrencyDisplay component #25278

Closed

Conversation

Devin-Apps
Copy link
Contributor

@Devin-Apps Devin-Apps commented Jun 12, 2024

Description

This PR introduces a Storybook story for the TokenCurrencyDisplay component to facilitate isolated UI testing and development.

Related issues

N/A

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the TokenCurrencyDisplay component in the Components/UI folder.

Screenshots/Recordings

Screenshot 2024-06-12 at 2 22 56 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Devin Run

Copy link
Contributor

github-actions bot commented Jun 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall requested a review from a team June 13, 2024 16:36
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 13, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettbear garrettbear marked this pull request as ready for review June 27, 2024 16:33
@garrettbear garrettbear requested a review from a team as a code owner June 27, 2024 16:33
@garrettbear
Copy link
Contributor

Try rebasing to see if it resolves the failing tests. The failures are not caused by this PR.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with develop branch should resolve this issue

@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed external-contributor labels Jul 25, 2024
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Introduced a Storybook story for the TokenCurrencyDisplay component to enable isolated UI testing and development.

  • Added ui/components/ui/token-currency-display/token-currency-display.stories.tsx to define the Storybook story.
  • Configured the story with metadata, including title and argument types.
  • Created a template for rendering the component with various props.
  • Set initial arguments for className, transactionData, token, and prefix in the default story instance.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@georgewrmarshall
Copy link
Contributor

Closing in favor of #26172 can't get Devin to reset soft and hard push to fix these tests

Screenshot 2024-07-26 at 3 05 58 PM

@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants