Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for TokenCurrencyDisplay component #26172

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Jul 26, 2024

Copy pasta of #25278

Description

This PR introduces a Storybook story for the TokenCurrencyDisplay component to facilitate isolated UI testing and development.

Related issues

N/A

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the TokenCurrencyDisplay component in the Components/UI folder.

Screenshots/Recordings

Screenshot 2024-06-12 at 2 22 56 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Devin Run

@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 26, 2024 22:05
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 26, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 26, 2024 22:05
Copy link

sonarcloud bot commented Jul 26, 2024

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (f938877) to head (d0460c5).
Report is 29 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26172   +/-   ##
========================================
  Coverage    69.93%   69.93%           
========================================
  Files         1409     1409           
  Lines        49786    49786           
  Branches     13769    13769           
========================================
  Hits         34817    34817           
  Misses       14969    14969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [d0460c5]
Page Load Metrics (137 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681601022311
domContentLoaded96329157
load411404137292140
domInteractive96329157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-30 at 9 38 26 AM LGTM

@georgewrmarshall georgewrmarshall added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 30, 2024
@georgewrmarshall georgewrmarshall merged commit 85c5710 into develop Jul 31, 2024
78 checks passed
@georgewrmarshall georgewrmarshall deleted the token-currency-display-story branch July 31, 2024 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 31, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-design-system All issues relating to design system in Extension
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants