chore: removes portfolio button & fixes code fence of receive modal #27286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NidhiKJha
previously approved these changes
Sep 19, 2024
…ask/metamask-extension into MMI-5489-remove-portfolio-new-link
albertolive
previously approved these changes
Sep 20, 2024
Builds ready [5718e63]
Page Load Metrics (1844 ± 155 ms)
Bundle size diffs
|
zone-live
commented
Sep 23, 2024
| @@ -34,6 +34,8 @@ const NoteToTrader: React.FC = () => { | |||
| getIsNoteToTraderSupported(state, fromChecksumHexAddress), | |||
| ); | |||
|
|
|||
| const MAX_LENGTH = 280; | |||
There was a problem hiding this comment.
zone-live
commented
Sep 23, 2024
| @@ -42,7 +44,11 @@ const NoteToTrader: React.FC = () => { | |||
| return () => clearTimeout(timer); | |||
| }, [noteText]); | |||
|
|
|||
| return isNoteToTraderSupported && !isSignature ? ( | |||
| if (!isNoteToTraderSupported || isSignature) { | |||
There was a problem hiding this comment.
@pedronfigueiredo And here.
|
Builds ready [2b8a98f]
Page Load Metrics (2011 ± 136 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Sep 23, 2024
shane-t
approved these changes
Sep 23, 2024
metamaskbot
added
the
release-12.6.0
metamaskbot
added
release-12.5.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In MMI we don't want to show the new Portfolio button, therefore we are code fencing it.
Fixes the "receive" modal for MMI build, because of a misplaced code fence.
Also adds a small code improvement for MMI note to trader component.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist