-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removes portfolio button & fixes code fence of receive modal #27286
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
05e9fe5
chore: fixes modal because of code fence and removes portfolio button…
zone-live 3d8e7d9
chore: lint fix
zone-live 094121c
Merge branch 'develop' into MMI-5489-remove-portfolio-new-link
zone-live 215e6fa
chore: undo change
zone-live 6099725
Merge branch 'MMI-5489-remove-portfolio-new-link' of github.com:MetaM…
zone-live 2fc57ab
chore: test update
zone-live 5718e63
Merge branch 'develop' into MMI-5489-remove-portfolio-new-link
zone-live 74a39b9
Merge branch 'develop' into MMI-5489-remove-portfolio-new-link
zone-live 2b8a98f
chore: small improvement
zone-live File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,8 @@ const NoteToTrader: React.FC = () => { | |
getIsNoteToTraderSupported(state, fromChecksumHexAddress), | ||
); | ||
|
||
const MAX_LENGTH = 280; | ||
|
||
useEffect(() => { | ||
const timer = setTimeout(() => { | ||
dispatch(setNoteToTraderMessage(noteText)); | ||
|
@@ -42,7 +44,11 @@ const NoteToTrader: React.FC = () => { | |
return () => clearTimeout(timer); | ||
}, [noteText]); | ||
|
||
return isNoteToTraderSupported && !isSignature ? ( | ||
if (!isNoteToTraderSupported || isSignature) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @pedronfigueiredo And here. |
||
return null; | ||
} | ||
|
||
return ( | ||
<Box | ||
backgroundColor={BackgroundColor.backgroundDefault} | ||
borderRadius={BorderRadius.MD} | ||
|
@@ -61,7 +67,7 @@ const NoteToTrader: React.FC = () => { | |
> | ||
<Label htmlFor="transaction-note">{t('transactionNote')}</Label> | ||
<Text className="note-header__counter"> | ||
{noteText.length}/{280} | ||
{noteText.length}/{MAX_LENGTH} | ||
</Text> | ||
</Box> | ||
<Box | ||
|
@@ -76,14 +82,14 @@ const NoteToTrader: React.FC = () => { | |
value={noteText} | ||
height={BlockSize.Full} | ||
width={BlockSize.Full} | ||
maxLength={280} | ||
maxLength={MAX_LENGTH} | ||
placeholder={t('notePlaceholder')} | ||
padding={2} | ||
/> | ||
</Box> | ||
</Box> | ||
</Box> | ||
) : null; | ||
); | ||
}; | ||
|
||
export default NoteToTrader; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedronfigueiredo 👍🏼