Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Oasis Sapphire Mainnet and Testnet #28168

Closed
wants to merge 1 commit into from

Conversation

aefhm
Copy link

@aefhm aefhm commented Oct 29, 2024

Description

Open in GitHub Codespaces

Related issues

Adds SVG icon for Oasis Sapphire Mainnet and Testnet similar to #27841

Close #28205

Manual testing steps

  1. Go to https://docs.oasis.io/dapp/sapphire/network/
  2. Click "Add to MetaMask"
  3. See that network icon is the new loaded SVG

Screenshots/Recordings

Before

Screen.Recording.2024-10-31.at.4.30.25.PM.mov

After

Screen.Recording.2024-10-31.at.4.35.16.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@aefhm
Copy link
Author

aefhm commented Oct 30, 2024

I have read the CLA Document and I hereby sign the CLA.

@aefhm aefhm force-pushed the develop branch 3 times, most recently from 50aeeed to 9e0e539 Compare October 31, 2024 18:04
shared/constants/network.ts Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the develop branch 2 times, most recently from 679eb8e to 0f6c5c6 Compare October 31, 2024 21:18
@aefhm aefhm marked this pull request as ready for review October 31, 2024 21:48
@aefhm aefhm requested a review from a team as a code owner October 31, 2024 21:48
@aefhm aefhm force-pushed the develop branch 2 times, most recently from ad541e5 to bfa0a2f Compare November 4, 2024 22:41
@aefhm aefhm force-pushed the develop branch 3 times, most recently from d760021 to 6b3534a Compare November 20, 2024 00:12
@aefhm aefhm closed this Dec 4, 2024
@aefhm aefhm deleted the develop branch December 4, 2024 23:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Add Network Icon for Shape
2 participants