-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: FMP spans for tokens and nfts tabs #28401
Draft
MajorLift
wants to merge
42
commits into
jongsun/perf/trace/241111-trace-features
Choose a base branch
from
jongsun/perf/trace/241111-account-watcher-additional-spans
base: jongsun/perf/trace/241111-trace-features
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
perf: FMP spans for tokens and nfts tabs #28401
MajorLift
wants to merge
42
commits into
jongsun/perf/trace/241111-trace-features
from
jongsun/perf/trace/241111-account-watcher-additional-spans
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab37660.
…rent tab finishes loading
This reverts commit 7c6fc74.
…OverviewTab` components
… or account overview tab
…en loading state is negated
…ion popover import button is clicked
…bName` getters with map data structures
…ng of traces" This reverts commit b79a95e.
…count-overview-tabs` to isolate presentational abstraction away from business logic
MajorLift
added
area-Sentry
error reporting to sentry
area-performance
Issues relating to slowness of app, cpu usage, and/or blank screens.
labels
Nov 11, 2024
MajorLift
added
the
team-tiger
Tiger team (for tech debt reduction + performance improvements)
label
Nov 11, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MajorLift
force-pushed
the
jongsun/perf/trace/241111-account-watcher-additional-spans
branch
from
November 11, 2024 11:24
383d659
to
2750cf3
Compare
MajorLift
force-pushed
the
jongsun/perf/trace/241111-account-watcher-additional-spans
branch
from
November 11, 2024 11:30
2750cf3
to
12a68ee
Compare
MajorLift
force-pushed
the
jongsun/perf/trace/241111-trace-features
branch
from
November 11, 2024 11:31
1634052
to
c73b201
Compare
7 tasks
MajorLift
force-pushed
the
jongsun/perf/trace/241111-trace-features
branch
from
November 21, 2024 14:33
c73b201
to
68d0265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-performance
Issues relating to slowness of app, cpu usage, and/or blank screens.
area-Sentry
error reporting to sentry
team-tiger
Tiger team (for tech debt reduction + performance improvements)
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Approach
Defines the following custom spans:
'Account Overview - Asset List Tab - First Contentful Paint'
'Account Overview - Nfts Tab - First Meaningful Paint'
ACCOUNT_OVERVIEW_TAB_KEY_TO_TRACE_NAME_MAP
intoACCOUNT_OVERVIEW_TAB_KEY_TO_TRACE_NAMES_ARRAY_MAP
.Behavior
'Account Overview - Nfts Tab - First Meaningful Paint'
:Results
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist