Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: FMP spans for tokens and nfts tabs #28401

Draft
wants to merge 42 commits into
base: jongsun/perf/trace/241111-trace-features
Choose a base branch
from

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Nov 11, 2024

Description

Open in GitHub Codespaces

Approach

Defines the following custom spans:

  • 'Account Overview - Asset List Tab - First Contentful Paint'
  • 'Account Overview - Nfts Tab - First Meaningful Paint'
  • Refactored object ACCOUNT_OVERVIEW_TAB_KEY_TO_TRACE_NAME_MAP into ACCOUNT_OVERVIEW_TAB_KEY_TO_TRACE_NAMES_ARRAY_MAP.

Behavior

  • Triggers a) when an account list item is clicked in the account list menu component, or b) when an account overview tab (e.g. "Tokens", "NFTs", "Activity") is clicked.
  • Terminates:
    • `'Account Overview - Asset List Tab - First Contentful Paint':
      • Component renders.
    • 'Account Overview - Nfts Tab - First Meaningful Paint':
      • If there is no data to display, the loading spinner disappears, and the appropriate filler content renders.
      • Otherwise, the first batch of NFT content is displayed, regardless of whether the loading spinner has disappeared or not.

Results

Screenshot 2024-11-05 at 1 32 10 PM Screenshot 2024-11-05 at 12 54 02 PM

Related issues

Fixes:

Manual testing steps

  1. Click one or more of the account overview tabs ("Tokens", "NFTs", "Activity").
  2. Click Account Menu
  3. Switch account and repeat.
  • Add accounts as necessary.
  • For load testing, add whale account(s) using the experimental "Watch Account" feature.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…count-overview-tabs` to isolate presentational abstraction away from business logic
@MajorLift MajorLift added area-Sentry error reporting to sentry area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. labels Nov 11, 2024
@MajorLift MajorLift added the team-tiger Tiger team (for tech debt reduction + performance improvements) label Nov 11, 2024
@MajorLift MajorLift self-assigned this Nov 11, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift force-pushed the jongsun/perf/trace/241111-account-watcher-additional-spans branch from 383d659 to 2750cf3 Compare November 11, 2024 11:24
@MajorLift MajorLift force-pushed the jongsun/perf/trace/241111-account-watcher-additional-spans branch from 2750cf3 to 12a68ee Compare November 11, 2024 11:30
@MajorLift MajorLift force-pushed the jongsun/perf/trace/241111-trace-features branch from 1634052 to c73b201 Compare November 11, 2024 11:31
@MajorLift MajorLift force-pushed the jongsun/perf/trace/241111-trace-features branch from c73b201 to 68d0265 Compare November 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. area-Sentry error reporting to sentry team-tiger Tiger team (for tech debt reduction + performance improvements) team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants