Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: FMP spans for tokens and nfts tabs #28401

Draft
wants to merge 42 commits into
base: jongsun/perf/trace/241111-trace-features
Choose a base branch
from
Draft

perf: FMP spans for tokens and nfts tabs #28401

wants to merge 42 commits into from
+215 −38

Commits on Oct 30, 2024

  1. Revert "feat: codefence Account Watcher for flask (#27543)" 

    This reverts commit ab37660.
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8ecf0b2 View commit details
    Browse the repository at this point in the history

  2. Add trace names for account list item and account overview tab

    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9924b50 View commit details
    Browse the repository at this point in the history

  3. Add trace calls for AccountListItem span

    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a4c46b7 View commit details
    Browse the repository at this point in the history

  4. Add trace calls for AccountOverviewTab span

    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    394d487 View commit details
    Browse the repository at this point in the history

  5. Abort AccountListItem span if account tab is switched

    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    39cc6f2 View commit details
    Browse the repository at this point in the history

  6. Abort AccountOverviewTab span if account tab is switched before cur… 

    …rent tab finishes loading
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    656dfdb View commit details
    Browse the repository at this point in the history

  7. Abort AccountOverviewTab span if new account is selected in account… 

    … list menu
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9f90b84 View commit details
    Browse the repository at this point in the history

  8. Abort AccountListItem span if new account is selected in account li… 

    …st menu
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    04d0694 View commit details
    Browse the repository at this point in the history

  9. Revert "Revert "feat: codefence Account Watcher for flask (#27543)"" 

    This reverts commit 7c6fc74.
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ccc6a34 View commit details
    Browse the repository at this point in the history

  10. Remove AccountOverviewTab, AccountListItem spans

    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e9b9aef View commit details
    Browse the repository at this point in the history

  11. Define custom spans AccountOverview{AssetList,Nfts,Activity}Tab

    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c53f8bb View commit details
    Browse the repository at this point in the history

  12. Place endTrace calls for new custom spans in corresponding `Account… 

    …OverviewTab` components
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b9fa09e View commit details
    Browse the repository at this point in the history

  13. Define utility functions {start,end}Traces for batch handling of tr… 

    …aces
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b79a95e View commit details
    Browse the repository at this point in the history

  14. Define new redux selector getDefaultHomeActiveTabName

    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b5046fd View commit details
    Browse the repository at this point in the history

  15. Trigger and terminate custom spans when clicking on account list item… 

    … or account overview tab
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    694e73d View commit details
    Browse the repository at this point in the history

  16. endTrace calls for "Tokens" and "Nfts" tab conditionally trigger wh… 

    …en loading state is negated
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c0f9811 View commit details
    Browse the repository at this point in the history

  17. Trigger AccountOverviewAssetListTab span when detected token select… 

    …ion popover import button is clicked
    @MajorLift
    MajorLift committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    21bbcf6 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Nfts tab span termination also requires nftsStillFetchingIndication… 

    … to be false
    @MajorLift
    MajorLift committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4fa73c1 View commit details
    Browse the repository at this point in the history

  2. Define types, constants for account overview tabs and replace `fromTa… 

    …bName` getters with map data structures
    @MajorLift
    MajorLift committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a5c2ae2 View commit details
    Browse the repository at this point in the history

  3. Revert "Define utility functions {start,end}Traces for batch handli… 

    …ng of traces"

This reverts commit b79a95e.
    @MajorLift
    MajorLift committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6bbef8e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into jongsun/perf/trace/241009-account-watcher

    @MajorLift
    MajorLift authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    26b2031 View commit details
    Browse the repository at this point in the history

  5. Linter fixes

    @MajorLift
    MajorLift committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f49728b View commit details
    Browse the repository at this point in the history

  6. Align types for defaultHomeActiveTabName

    @MajorLift
    MajorLift committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0d914ec View commit details
    Browse the repository at this point in the history

  7. Fix import order

    @MajorLift
    MajorLift committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9c33083 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Remove AccountOverviewTabKeys enum union type

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cfcc492 View commit details
    Browse the repository at this point in the history

  2. Move detectNfts dispatch call out of component library and into `ac… 

    …count-overview-tabs` to isolate presentational abstraction away from business logic
    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    df17187 View commit details
    Browse the repository at this point in the history

  3. Add endTrace call for case where NftsTab displays the empty banner

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f3c989b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into jongsun/perf/trace/241009-account-watcher

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3790fc4 View commit details
    Browse the repository at this point in the history

  5. feat: Add support for adding tags in endTrace calls

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8c9638f View commit details
    Browse the repository at this point in the history

  6. Add jsdoc comment for AccountList span

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ed5dcab View commit details
    Browse the repository at this point in the history

  7. Add support for custom span operation names

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1329fdb View commit details
    Browse the repository at this point in the history

  8. Add custom span operation 'custom.ui.component_load'

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    945a5b5 View commit details
    Browse the repository at this point in the history

  9. Define utility functions {start,end}Traces for batch handling of tr… 

    …aces
    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c73b201 View commit details
    Browse the repository at this point in the history

  10. Add ui.event.abort tags to endTrace calls

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f55315e View commit details
    Browse the repository at this point in the history

  11. Add missing ui.event.abort tag

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e292805 View commit details
    Browse the repository at this point in the history

  12. Add FMP spans for tokens and NFTs tabs

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7662a32 View commit details
    Browse the repository at this point in the history

  13. Add trace calls for detected token selection popover

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1c80ed2 View commit details
    Browse the repository at this point in the history

  14. Linter fixes

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c1e1012 View commit details
    Browse the repository at this point in the history

  15. Refactor tokens tab custom spans to measure FCP, FMP

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fa73d06 View commit details
    Browse the repository at this point in the history

  16. Fix logic for triggering nft tabs spans endTrace calls

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d10461c View commit details
    Browse the repository at this point in the history

  17. Ensure traces don't terminate while nftsLoading is true

    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    1f25af3 View commit details
    Browse the repository at this point in the history

  18. Consolidate useEffect for NftsTab when empty nfts banner is displ… 

    …ayed
    @MajorLift
    MajorLift committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    12a68ee View commit details
    Browse the repository at this point in the history