feat: adding tooltip to signature decoding state changes #28430

jpuri · 2024-11-13T05:17:42Z

Description

Add tooltip to state change labels.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3628

Manual testing steps

Enable signature decoding locally.
Check NFT bidding or listing permit
It should show appropriate tooltip

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…sion into decoding_api_int

…tension into decoding_ui_changes

…extension into decoded_token_display

github-actions · 2024-11-13T05:17:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…xtension into native_value_display

…extension into state_change_tooltips

metamaskbot · 2024-11-16T14:51:06Z

Builds ready [6debf04]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1825 ± 122 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	374	2397	1660	478	230
		domContentLoaded	1550	2258	1799	237	114
		load	1558	2411	1825	254	122
		domInteractive	28	233	53	44	21
		backgroundConnect	8	196	27	43	21
		firstReactRender	53	313	134	64	31
		getState	4	52	16	15	7
		initialActions	0	0	0	0	0
		loadScripts	1119	1687	1316	182	87
		setupStore	5	83	20	23	11
		uiStartup	1749	2984	2123	344	165

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -106.79 KiB (-1.76%)
ui: 8.64 KiB (0.11%)
common: 107.31 KiB (1.30%)

metamaskbot · 2024-11-22T11:18:27Z

Builds ready [d969a07]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1874 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1664	2279	1879	203	98
		domContentLoaded	1642	2262	1851	192	92
		load	1665	2280	1874	198	95
		domInteractive	24	153	50	34	16
		backgroundConnect	12	71	33	18	9
		firstReactRender	66	306	139	66	32
		getState	4	59	10	12	6
		initialActions	0	1	0	0	0
		loadScripts	1174	1711	1364	163	78
		setupStore	6	88	24	27	13
		uiStartup	1852	2817	2174	270	130

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 553 Bytes (0.01%)
common: 210 Bytes (0.00%)

metamaskbot · 2024-11-22T12:35:39Z

Builds ready [dc8f1b9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2048 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	248	2327	1947	423	203
		domContentLoaded	1756	2284	2004	150	72
		load	1786	2372	2048	160	77
		domInteractive	17	98	39	21	10
		backgroundConnect	13	129	36	28	13
		firstReactRender	75	152	110	21	10
		getState	5	73	33	27	13
		initialActions	0	1	0	0	0
		loadScripts	1257	1737	1486	133	64
		setupStore	7	60	13	14	7
		uiStartup	1986	2584	2272	169	81

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 553 Bytes (0.01%)
common: 210 Bytes (0.00%)

metamaskbot · 2024-11-22T13:14:57Z

Builds ready [bc0f21f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1874 ± 144 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	432	2364	1776	397	191
		domContentLoaded	1545	2571	1852	291	140
		load	1553	2663	1874	300	144
		domInteractive	22	167	41	31	15
		backgroundConnect	10	103	27	23	11
		firstReactRender	44	314	119	62	30
		getState	4	68	20	21	10
		initialActions	0	0	0	0	0
		loadScripts	1103	1898	1366	231	111
		setupStore	5	78	20	22	10
		uiStartup	1745	3163	2140	415	199

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 553 Bytes (0.01%)
common: 210 Bytes (0.00%)

digiwand · 2024-11-22T14:55:31Z

...mponents/confirm/info/typed-sign/permit-simulation/decoded-simulation/decoded-simulation.tsx

+      return t('signature_decoding_list_nft_tooltip');
+    }
+    if (
+      stateChange.assetType === TokenStandard.ERC721 &&


Q:

we check the assetType on stateChange here and the assetType on the change of the list item above. Did we want to keep this as is or update to be consistent?

Above is filter applied to whole list of state changes, and here we are checking seet of single state change.

right. Thanks for confirming this is expected!

jpuri and others added 26 commits November 7, 2024 14:56

UI changes to show decoding data for permits

03b89d8

Merge branch 'develop' into decoding_ui_changes

75026e4

Display ERC20 and ERC721 token details returns by decoding api

7fed6fa

Merge branch 'decoding_ui_changes' into decoded_token_display

cac71e1

Display native values returned from decoding api

8457fd3

Display native values returned from decoding api

569abbc

Display native values returned from decoding api

4810bdd

Display native values returned from decoding api

399086b

Update signature controller and integrate decoding api

602fb20

Update signature controller and integrate decoding api

fc6ab5e

Update LavaMoat policies

228796c

update

2943ebf

Merge branch 'decoding_api_int' of github.com:MetaMask/metamask-exten…

4b04930

…sion into decoding_api_int

UI changes to show decoding data for permits

25e9a00

Merge branch 'decoding_ui_changes' of github.com:MetaMask/metamask-ex…

fbfdfa3

…tension into decoding_ui_changes

Merge branch 'decoding_ui_changes' into decoded_token_display

cdbfe3b

update

45f64fe

Merge branch 'decoded_token_display' of github.com:MetaMask/metamask-…

dcc66cc

…extension into decoded_token_display

update

b4347bf

update

c9fed99

Merge branch 'decoded_token_display' into native_value_display

494fb15

update

8671d56

update

82f42b0

update

a24d06c

update

8de0e98

Adding tooltip to signature decoding state changes

4100431

jpuri added the team-confirmations Push issues to confirmations team label Nov 13, 2024

jpuri requested review from a team as code owners November 13, 2024 05:17

jpuri added 7 commits November 16, 2024 16:42

update

d4b7eb5

Merge branch 'native_value_display' of github.com:MetaMask/metamask-e…

7cc5d0b

…xtension into native_value_display

update

ed4aba6

update

e437a1b

Merge branch 'native_value_display' into state_change_tooltips

6e4de16

Merge branch 'state_change_tooltips' of github.com:MetaMask/metamask-…

571b540

…extension into state_change_tooltips

update

6debf04

Base automatically changed from native_value_display to develop November 22, 2024 00:50

update

d969a07

jpuri changed the title ~~Adding tooltip to signature decoding state changes~~ feat: adding tooltip to signature decoding state changes Nov 22, 2024

jpuri added 4 commits November 22, 2024 17:07

update

dda245a

update

cc65aee

update

1666356

update

dc8f1b9

pedronfigueiredo approved these changes Nov 22, 2024

View reviewed changes

Merge branch 'develop' into state_change_tooltips

bc0f21f

jpuri enabled auto-merge November 22, 2024 12:42

digiwand reviewed Nov 22, 2024

View reviewed changes

jpuri requested a review from digiwand November 25, 2024 11:02

digiwand approved these changes Nov 25, 2024

View reviewed changes

jpuri added this pull request to the merge queue Nov 25, 2024

Merged via the queue into develop with commit 67b2f5a Nov 25, 2024
75 checks passed

jpuri deleted the state_change_tooltips branch November 25, 2024 11:35

github-actions bot locked and limited conversation to collaborators Nov 25, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding tooltip to signature decoding state changes #28430

feat: adding tooltip to signature decoding state changes #28430

jpuri commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024

metamaskbot commented Nov 16, 2024

metamaskbot commented Nov 22, 2024

metamaskbot commented Nov 22, 2024

metamaskbot commented Nov 22, 2024

digiwand Nov 22, 2024

jpuri Nov 25, 2024

digiwand Nov 25, 2024

feat: adding tooltip to signature decoding state changes #28430

feat: adding tooltip to signature decoding state changes #28430

Conversation

jpuri commented Nov 13, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 13, 2024

metamaskbot commented Nov 16, 2024

metamaskbot commented Nov 22, 2024

metamaskbot commented Nov 22, 2024

metamaskbot commented Nov 22, 2024

digiwand Nov 22, 2024

Choose a reason for hiding this comment

jpuri Nov 25, 2024

Choose a reason for hiding this comment

digiwand Nov 25, 2024

Choose a reason for hiding this comment

jpuri commented Nov 13, 2024 •

edited

Loading