feat: adding tooltip to signature decoding state changes

ui/pages/confirmations/components/confirm/info/typed-sign/permit-simulation/decoded-simulation/decoded-simulation.test.tsx

@@ -3,12 +3,13 @@ import configureMockStore from 'redux-mock-store';
 import {
   DecodingData,
   DecodingDataChangeType,
+  DecodingDataStateChanges,
 } from '@metamask/signature-controller';
 
 import { getMockTypedSignConfirmStateForRequest } from '../../../../../../../../../test/data/confirmations/helper';
 import { renderWithConfirmContextProvider } from '../../../../../../../../../test/lib/confirmations/render-helpers';
 import { permitSignatureMsg } from '../../../../../../../../../test/data/confirmations/typed_sign';
-import PermitSimulation from './decoded-simulation';
+import PermitSimulation, { getStateChangeToolip } from './decoded-simulation';
 
 const decodingData: DecodingData = {
   stateChanges: [
@@ -22,6 +23,42 @@ const decodingData: DecodingData = {
   ],
 };
 
+const decodingDataListing: DecodingDataStateChanges = [
+  {
+    assetType: 'NATIVE',
+    changeType: DecodingDataChangeType.Receive,
+    address: '',
+    amount: '900000000000000000',
+    contractAddress: '',
+  },
+  {
+    assetType: 'ERC721',
+    changeType: DecodingDataChangeType.Listing,
+    address: '',
+    amount: '',
+    contractAddress: '0xafd4896984CA60d2feF66136e57f958dCe9482d5',
+    tokenID: '2101',
+  },
+];
+
+const decodingDataBidding: DecodingDataStateChanges = [
+  {
+    assetType: 'ERC721',
+    changeType: DecodingDataChangeType.Receive,
+    address: '',
+    amount: '900000000000000000',
+    contractAddress: '',
+  },
+  {
+    assetType: 'Native',
+    changeType: DecodingDataChangeType.Bidding,
+    address: '',
+    amount: '',
+    contractAddress: '0xafd4896984CA60d2feF66136e57f958dCe9482d5',
+    tokenID: '2101',
+  },
+];
+
 describe('DecodedSimulation', () => {
   it('renders component correctly', async () => {
     const state = getMockTypedSignConfirmStateForRequest({
@@ -38,4 +75,24 @@ describe('DecodedSimulation', () => {
 
     expect(container).toMatchSnapshot();
   });
+
+  describe('getStateChangeToolip', () => {
+    it('return correct tooltip when permit is for listing NFT', async () => {
+      const tooltip = getStateChangeToolip(
+        decodingDataListing,
+        decodingDataListing?.[0],
+        (str: string) => str,
+      );
+      expect(tooltip).toBe('signature_decoding_list_nft_tooltip');
+    });
+  });
+
+  it('return correct tooltip when permit is for bidding NFT', async () => {
+    const tooltip = getStateChangeToolip(
+      decodingDataBidding,
+      decodingDataBidding?.[0],
+      (str: string) => str,
+    );
+    expect(tooltip).toBe('signature_decoding_bid_nft_tooltip');
+  });
 });

ui/pages/confirmations/components/confirm/info/typed-sign/permit-simulation/decoded-simulation/decoded-simulation.tsx

@@ -2,6 +2,7 @@ import React from 'react';
 import {
   DecodingDataChangeType,
   DecodingDataStateChange,
+  DecodingDataStateChanges,
 } from '@metamask/signature-controller';
 import { Hex } from '@metamask/utils';
 
@@ -11,8 +12,35 @@ import { useI18nContext } from '../../../../../../../../hooks/useI18nContext';
 import { SignatureRequestType } from '../../../../../../types/confirm';
 import { useConfirmContext } from '../../../../../../context/confirm';
 import StaticSimulation from '../../../shared/static-simulation/static-simulation';
-import NativeValueDisplay from '../native-value-display/native-value-display';
 import TokenValueDisplay from '../value-display/value-display';
+import NativeValueDisplay from '../native-value-display/native-value-display';
+
+export const getStateChangeToolip = (
+  stateChangeList: DecodingDataStateChanges | null,
+  stateChange: DecodingDataStateChange,
+  t: ReturnType<typeof useI18nContext>,
+): string | undefined => {
+  if (stateChange.changeType === DecodingDataChangeType.Receive) {
+    if (
+      stateChangeList?.some(
+        (change) =>
+          change.changeType === DecodingDataChangeType.Listing &&
+          change.assetType === TokenStandard.ERC721,
+      )
+    ) {
+      return t('signature_decoding_list_nft_tooltip');
+    }
+    if (
+      stateChange.assetType === TokenStandard.ERC721 &&
+      stateChangeList?.some(
+        (change) => change.changeType === DecodingDataChangeType.Bidding,
+      )
+    ) {
+      return t('signature_decoding_bid_nft_tooltip');
+    }
+  }
+  return undefined;
+};
 
 const getStateChangeLabelMap = (
   t: ReturnType<typeof useI18nContext>,
@@ -28,17 +56,23 @@ const getStateChangeLabelMap = (
   }[changeType]);
 
 const StateChangeRow = ({
+  stateChangeList,
   stateChange,
   chainId,
 }: {
+  stateChangeList: DecodingDataStateChanges | null;
   stateChange: DecodingDataStateChange;
   chainId: Hex;
 }) => {
   const t = useI18nContext();
   const { assetType, changeType, amount, contractAddress, tokenID } =
     stateChange;
+  const tooltip = getStateChangeToolip(stateChangeList, stateChange, t);
   return (
-    <ConfirmInfoRow label={getStateChangeLabelMap(t, changeType)}>
+    <ConfirmInfoRow
+      label={getStateChangeLabelMap(t, changeType)}
+      tooltip={tooltip}
+    >
       {(assetType === TokenStandard.ERC20 ||
         assetType === TokenStandard.ERC721) && (
         <TokenValueDisplay
@@ -70,7 +104,11 @@ const DecodedSimulation: React.FC<object> = () => {
 
   const stateChangeFragment = (decodingData?.stateChanges ?? []).map(
     (change: DecodingDataStateChange) => (
-      <StateChangeRow stateChange={change} chainId={chainId} />
+      <StateChangeRow
+        stateChangeList={decodingData?.stateChanges ?? []}
+        stateChange={change}
+        chainId={chainId}
+      />
     ),
   );
 

ui/pages/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

@@ -11,7 +11,7 @@ const PermitSimulation: React.FC<object> = () => {
 
   if (
     decodingData?.error ||
-    (decodingData === undefined && decodingLoading !== true)
+    (decodingData?.stateChanges === undefined && decodingLoading !== true)
   ) {
     return <DefaultSimulation />;
   }

ui/pages/confirmations/components/confirm/info/typed-sign/permit-simulation/value-display/value-display.tsx

@@ -21,16 +21,15 @@ import {
 } from '../../../../../../../../components/component-library';
 import Tooltip from '../../../../../../../../components/ui/tooltip';
 import {
-  BackgroundColor,
   BlockSize,
   BorderRadius,
   Display,
   JustifyContent,
   TextAlign,
-  TextColor,
 } from '../../../../../../../../helpers/constants/design-system';
 import Name from '../../../../../../../../components/app/name/name';
 import { TokenDetailsERC20 } from '../../../../../../utils/token';
+import { getAmountColors } from '../../../utils';
 
 type PermitSimulationValueDisplayParams = {
   /** ID of the associated chain. */
@@ -112,16 +111,7 @@ const PermitSimulationValueDisplay: React.FC<
     return null;
   }
 
-  let valueColor = TextColor.textDefault;
-  let valueBackgroundColor = BackgroundColor.backgroundAlternative;
-
-  if (credit) {
-    valueColor = TextColor.successDefault;
-    valueBackgroundColor = BackgroundColor.successMuted;
-  } else if (debit) {
-    valueColor = TextColor.errorDefault;
-    valueBackgroundColor = BackgroundColor.errorMuted;
-  }
+  const { color, backgroundColor } = getAmountColors(credit, debit);
 
   return (
     <Box marginLeft="auto" style={{ maxWidth: '100%' }}>
@@ -139,9 +129,9 @@ const PermitSimulationValueDisplay: React.FC<
           >
             <Text
               data-testid="simulation-token-value"
-              backgroundColor={valueBackgroundColor}
+              backgroundColor={backgroundColor}
               borderRadius={BorderRadius.XL}
-              color={valueColor}
+              color={color}
               paddingInline={2}
               style={{ paddingTop: '1px', paddingBottom: '1px' }}
               textAlign={TextAlign.Center}