Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade transaction controller to increase polling rate #28452

Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 13, 2024

Description

Upgrade @metamask/transaction-controller to increase the pending transaction polling rate.

Open in GitHub Codespaces

Related issues

Fixes: #3629

Manual testing steps

Regression of pending transaction polling including:

  • Alternate Chains
  • Queued Transactions
  • Sequential Transactions
  • Multiple Transactions

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f544c1c]
Page Load Metrics (2133 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40027052048435209
domContentLoaded16822637209220599
load16912644213320699
domInteractive17129592512
backgroundConnect1095342412
firstReactRender943051396531
getState65920188
initialActions00000
loadScripts11981964154816479
setupStore684202412
uiStartup189129842423272131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 3.44 KiB (0.04%)

@sleepytanya
Copy link
Contributor

@matthewwalsh0
Blockaid message is shown for Legacy and EIP 1559 transaction:

Screen.Recording.2024-11-15.at.12.37.40.mov

@sleepytanya
Copy link
Contributor

Sometimes STX is created with 0 gas fee, tx fails:

stxZeroGas.mov

I also see console gas errors messages on Linea (can't reproduce, probably need fresh install), tx can be successfully submitted:

Screenshot 2024-11-19 at 02 52 26 Screenshot 2024-11-19 at 02 52 09

@sleepytanya
Copy link
Contributor

Other functionality including queueing, nonce customization, cancel / speed up, multiple transactions on different networks function as expected.
I can't check STX + txs on other network due to the bug not related to current PR - #28517

@sleepytanya
Copy link
Contributor

sleepytanya commented Nov 20, 2024

Latest develop build

  1. No Blockaid validation is shown for Legacy and EIP 1559 transactions:
Screen.Recording.2024-11-19.at.22.31.10.mov
  1. I can't reproduce zero gas STX and gas fee errors on Linea in both develop and current PR build

@metamaskbot
Copy link
Collaborator

Builds ready [1ba6faf]
Page Load Metrics (1869 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36321721726450216
domContentLoaded16342115183413163
load16782154186913967
domInteractive147839157
backgroundConnect7103402914
firstReactRender563811459244
getState392071155929
initialActions00000
loadScripts12241627137310952
setupStore687233015
uiStartup190129042324299144
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 3.44 KiB (0.04%)

@sleepytanya
Copy link
Contributor

Blockaid Legacy and EIP 1559 issue wasn't related to the current PR, fixed after merging the latest develop:

Screen.Recording.2024-11-20.at.13.58.53.mov

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 21, 2024 10:40
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 21, 2024 10:40
@metamaskbot
Copy link
Collaborator

Builds ready [86e4dd6]
Page Load Metrics (2083 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43925132016411197
domContentLoaded17412490204918991
load17552517208319996
domInteractive32286717235
backgroundConnect10102392713
firstReactRender67217993215
getState4312588209
initialActions00000
loadScripts12831976154217082
setupStore66313147
uiStartup199530702418245117
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 3.44 KiB (0.04%)

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit c20ac99 Nov 21, 2024
75 checks passed
@matthewwalsh0 matthewwalsh0 deleted the chore/upgrade-transaction-controller-polling-rate branch November 21, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants