Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump Snaps packages #28557

Merged
merged 4 commits into from
Nov 20, 2024
Merged

chore: Bump Snaps packages #28557

merged 4 commits into from
Nov 20, 2024
+74 −50

Commits on Nov 20, 2024

  1. chore: Bump Snaps packages

    @FrederikBolding
    FrederikBolding committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    54d9ff4 View commit details
    Browse the repository at this point in the history

  2. Add notification services controller event

    @FrederikBolding
    FrederikBolding committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    535eb3d View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @FrederikBolding
    FrederikBolding committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    345fbe3 View commit details
    Browse the repository at this point in the history

  4. feat(snaps): Add support for Address in Card title (#28539) 

    ## **Description**

This PR adds support for the `Address` component in the `Card` title
following this PR: MetaMask/snaps#2894

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28539?quickstart=1)

## **Related issues**

## **Manual testing steps**

```jsx
<Card
  image='foo'
  title={<Address address={your address in MetaMask} displayName avatar={false} />}
  description='bar'
  extra='foobar'
/>
```

## **Screenshots/Recordings**


![241119_12h11m39s_screenshot](https://github.com/user-attachments/assets/9b32d7f6-aef4-415b-800a-350cde6696d8)


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @GuillaumeRx
    GuillaumeRx authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7545970 View commit details
    Browse the repository at this point in the history