Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass along decimal balance from asset-page to swaps UI #28707

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Nov 25, 2024

Description

Decimal balance are needed to be passed along with the rest of the token info in order to properly prepopulate the swaps UI.

Open in GitHub Codespaces

Related issues

Fixes: #28509

Manual testing steps

  1. Navigate from AssetList to TokenDetails to Swap UI
  2. Populate text field with a balance amount
  3. If balance is lower than the token balance, do not show the warning.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review November 25, 2024 23:32
@gambinish gambinish requested a review from a team as a code owner November 25, 2024 23:32
@metamaskbot
Copy link
Collaborator

Builds ready [73ccf25]
Page Load Metrics (1688 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14952044168712962
domContentLoaded14862016166512359
load14952048168813062
domInteractive227639189
backgroundConnect106425157
firstReactRender1673392311
getState56612168
initialActions00000
loadScripts10941532122710550
setupStore65414178
uiStartup16842232187213464
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 240 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 9fccd00 Nov 26, 2024
75 checks passed
@gambinish gambinish deleted the fix/issue-28532--zero-balance-swap-bug branch November 26, 2024 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets
Projects
None yet
4 participants