Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 62430fb (#28573) to v12.7.2 #28711

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Nov 26, 2024

Cherry pick 62430fb (#28573) to v12.7.2

…id exceeding our quota (#28573)

## **Description**

- Divide by 2 our sentry trace sample rate to avoid exceeding our quota

## **Related issues**

Fixes: None

## **Manual testing steps**

- None

## **Screenshots/Recordings**

- None

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Harika <153644847+hjetpoluru@users.noreply.github.com>
@danjm danjm requested review from a team and kumavis as code owners November 26, 2024 02:14
@danjm danjm changed the base branch from develop to Version-v12.7.2 November 26, 2024 02:14
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm merged commit 8724b63 into Version-v12.7.2 Nov 26, 2024
10 of 13 checks passed
@danjm danjm deleted the cherry-pick-62430fb-12.7.2 branch November 26, 2024 02:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4e41eee]
Page Load Metrics (2203 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36723982114410197
domContentLoaded2038234321627636
load2062240322038842
domInteractive177845157
backgroundConnect886332412
firstReactRender602161063115
getState675292412
initialActions01000
loadScripts1469175416077737
setupStore1371322211
uiStartup2282264224499747

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants