Skip to content

Conversation

@aganglada
Copy link
Contributor

@aganglada aganglada commented Feb 27, 2025

Description

Moving solana code fences to beta

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-new-networks PRs from the New Networks team label Feb 27, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Feb 27, 2025
ccharly
ccharly previously approved these changes Feb 27, 2025
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly tested with:

yarn build --build-type beta dist

I was able to see the account creation and use the Snap:

Screenshot 2025-02-27 at 20 46 49 Screenshot 2025-02-27 at 20 46 56 Screenshot 2025-02-27 at 20 47 32

Here we are 🥹 🚀

danroc
danroc previously approved these changes Feb 27, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Feb 27, 2025
@aganglada aganglada dismissed stale reviews from danroc and ccharly via 14d9a52 February 27, 2025 20:18
@aganglada aganglada requested review from a team as code owners February 27, 2025 20:18
@aganglada aganglada force-pushed the feat/move-solana-beta branch from 14d9a52 to bc571df Compare February 27, 2025 20:20
@aganglada aganglada enabled auto-merge February 27, 2025 20:23
});
});

it('returna config when not matching default mapping', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (though not introduced by this PR):

Suggested change
it('returna config when not matching default mapping', async () => {
it('returns config when not matching default mapping', async () => {

@aganglada aganglada added this pull request to the merge queue Feb 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [bc571df]
Page Load Metrics (1628 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14542018162912459
domContentLoaded14391971160811756
load14482066162813163
domInteractive26108402311
backgroundConnect1091252010
firstReactRender1569292110
getState559182010
initialActions00000
loadScripts1027145311889847
setupStore75712115
uiStartup16552411184515976
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 12 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit e1444c9 Feb 27, 2025
79 checks passed
@aganglada aganglada deleted the feat/move-solana-beta branch February 27, 2025 21:26
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Feb 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-new-networks PRs from the New Networks team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants