Skip to content

Conversation

@pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Mar 31, 2025

Cherry-pick: #31335

This introduces three high-priority core repo PRs in this release:

--- // ---

Fix balance change simulation of type-4 transactions by bumping @metamask/transaction-controller to 52.3.0.

Open in GitHub Codespaces

Fixes:
#4506

  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding
    Standards
    .

  • I've completed the PR template to the best of my ability

  • I’ve included tests if applicable

  • I’ve documented my code using JSDoc format if applicable

  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Fix balance change simulation of type-4 transactions by bumping
`@metamask/transaction-controller` to `52.3.0`.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31335?quickstart=1)

Fixes:
[#4506](MetaMask/MetaMask-planning#4506)

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Mar 31, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Mar 31, 2025
@pedronfigueiredo pedronfigueiredo changed the title fix: simulation of type-4 transactions (#31335) chore: Bump transaction controller version Mar 31, 2025
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@52.2.052.3.0 None 0 2.68 MB metamaskbot

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [35ff1b0]
UI Startup Metrics (1207 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1207109114516112471304
load10489301231561170985
domContentLoaded1042919122657919981
domInteractive17134651627
firstPaint699761234414261981
backgroundConnect106444910
firstReactRender19144041925
getState12546868
initialActions001001
loadScripts825692100757856908
setupStore7418278
WebpackHomeuiStartup985815126080981994
load83962494858869936
domContentLoaded83260294457864925
domInteractive16123871535
firstPaint53854946346856888
backgroundConnect17114881539
firstReactRender15123551430
getState7413279
initialActions001001
loadScripts83059294357863915
setupStore8547478
FirefoxBrowserifyHomeuiStartup13981181199815614551792
load12591058185415513231629
domContentLoaded12581058185315513231629
domInteractive10139194259197
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23164852633
firstReactRender23195662530
getState7413279
initialActions001001
loadScripts12361041183415413021604
setupStore6337467
WebpackHomeuiStartup9798451473139893962
load8597411251126842962
domContentLoaded8597411250126842962
domInteractive113341832614896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19137372030
firstReactRender18162721822
getState94651179
initialActions001001
loadScripts8437271226122831951
setupStore8548678

@MajorLift MajorLift merged commit 064270f into Version-v12.16.0 Apr 1, 2025
146 checks passed
@MajorLift MajorLift deleted the pnf/cherry-pick-gas-polling branch April 1, 2025 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants