chore: upgrade assets controllers to v58.0.0 #32019

sahar-fehri · 2025-04-15T21:33:46Z

Description

This PR bumps @metamask/assets-controllers to v58

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-15T21:33:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-04-16T15:19:35Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/assets-controllers@56.0.0 ⏵ 58.0.0	⁺³		⁺¹	⁺¹

View full report

socket-security · 2025-04-17T12:49:05Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

@metamask/assets-controllers@58.0.0

View full report

sahar-fehri · 2025-04-17T12:52:58Z

@SocketSecurity ignore-all

sahar-fehri · 2025-04-17T13:06:30Z

@metamaskbot update-policies

metamaskbot · 2025-04-17T13:21:52Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-04-17T13:24:01Z

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

📜 @MetaMask/policy-reviewers

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

🔗 @MetaMask/supply-chain

lavamoat/browserify/beta/policy.json
lavamoat/browserify/flask/policy.json
lavamoat/browserify/main/policy.json
lavamoat/browserify/mmi/policy.json

metamaskbot · 2025-04-17T16:29:24Z

Builds ready [ea422ed]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1188 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1188	1073	1405	57	1224	1288
			load	1036	934	1235	50	1065	1121
			domContentLoaded	1030	930	1227	50	1059	1115
			domInteractive	17	13	60	7	16	29
			firstPaint	729	114	1235	402	1049	1107
			backgroundConnect	6	4	19	2	7	9
			firstReactRender	21	15	42	6	21	37
			getState	11	4	44	8	16	26
			initialActions	0	0	1	0	0	1
			loadScripts	793	707	989	49	823	875
			setupStore	7	4	19	2	8	12
	Webpack	Home	uiStartup	2100	1697	2457	176	2239	2348
			load	1625	1285	2013	132	1725	1826
			domContentLoaded	1619	1280	2009	132	1718	1819
			domInteractive	16	11	61	11	13	52
			firstPaint	183	74	457	67	230	302
			backgroundConnect	24	9	68	13	28	59
			firstReactRender	205	55	399	124	346	362
			getState	13	4	222	22	12	26
			initialActions	3	1	7	1	3	5
			loadScripts	1614	1279	1984	131	1716	1817
			setupStore	19	6	327	32	20	31
Firefox	Browserify	Home	uiStartup	1354	1163	1709	121	1408	1613
			load	1208	1010	1571	122	1270	1437
			domContentLoaded	1207	1009	1571	122	1270	1437
			domInteractive	104	40	290	32	116	157
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	12	115	15	20	40
			firstReactRender	22	19	55	4	22	26
			getState	7	3	28	4	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1188	995	1556	119	1254	1421
			setupStore	8	4	200	20	6	7
	Webpack	Home	uiStartup	1501	1324	2046	126	1581	1734
			load	1283	1155	1744	110	1345	1506
			domContentLoaded	1282	1153	1744	110	1345	1506
			domInteractive	81	55	292	32	83	152
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	15	76	8	22	35
			firstReactRender	35	28	59	5	38	45
			getState	9	4	51	7	9	28
			initialActions	0	0	2	1	1	1
			loadScripts	1263	1140	1721	109	1323	1482
			setupStore	9	5	32	6	8	27

metamaskbot · 2025-04-17T17:24:56Z

Builds ready [80d560b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1083	1377	63	1235	1307
			load	1034	940	1246	55	1071	1130
			domContentLoaded	1027	936	1241	55	1062	1123
			domInteractive	16	13	29	4	16	27
			firstPaint	682	92	1246	411	1041	1107
			backgroundConnect	8	4	24	4	8	19
			firstReactRender	20	15	42	5	20	36
			getState	12	5	46	8	16	30
			initialActions	0	0	1	0	0	1
			loadScripts	792	710	975	52	825	876
			setupStore	7	4	15	2	8	12
	Webpack	Home	uiStartup	2137	1701	2611	160	2250	2349
			load	1653	1303	2028	126	1742	1855
			domContentLoaded	1646	1300	2002	125	1738	1832
			domInteractive	16	11	64	10	13	48
			firstPaint	186	71	548	74	239	310
			backgroundConnect	25	9	85	16	28	71
			firstReactRender	225	54	373	120	336	357
			getState	11	4	34	5	13	21
			initialActions	3	1	6	1	3	5
			loadScripts	1641	1298	1979	124	1737	1815
			setupStore	25	6	298	48	21	41
Firefox	Browserify	Home	uiStartup	1339	1182	1700	117	1401	1570
			load	1188	1015	1579	115	1273	1427
			domContentLoaded	1188	1015	1579	115	1272	1426
			domInteractive	104	38	252	40	122	183
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	90	10	20	28
			firstReactRender	22	18	49	4	22	28
			getState	11	4	185	25	8	19
			initialActions	0	0	1	0	0	1
			loadScripts	1170	1001	1566	115	1248	1408
			setupStore	10	3	180	24	6	28
	Webpack	Home	uiStartup	1478	1324	1948	110	1546	1679
			load	1259	1121	1491	91	1326	1434
			domContentLoaded	1259	1120	1491	92	1326	1434
			domInteractive	81	41	259	30	87	133
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	80	8	22	33
			firstReactRender	35	29	56	5	37	44
			getState	10	5	168	16	9	22
			initialActions	1	0	2	1	1	1
			loadScripts	1240	1106	1472	91	1308	1419
			setupStore	11	5	274	27	8	21

Bundle size diffs [🚀 Bundle size reduced!]

background: 161 Bytes (0%)
ui: 67 Bytes (0%)
common: -56.32 KiB (-0.6%)

metamaskbot · 2025-04-17T18:58:53Z

Builds ready [71735f2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1205	1093	1391	55	1237	1306
			load	1042	952	1239	51	1069	1136
			domContentLoaded	1036	948	1233	51	1062	1127
			domInteractive	18	13	62	9	16	29
			firstPaint	633	73	1246	422	1047	1135
			backgroundConnect	7	4	18	2	7	10
			firstReactRender	21	16	46	6	22	36
			getState	15	5	79	10	20	31
			initialActions	0	0	1	0	0	0
			loadScripts	800	714	995	49	826	886
			setupStore	8	5	37	4	8	14
	Webpack	Home	uiStartup	2075	1718	2449	165	2192	2361
			load	1609	1303	1910	131	1716	1830
			domContentLoaded	1603	1296	1896	131	1708	1821
			domInteractive	15	11	49	8	13	42
			firstPaint	177	70	330	56	206	278
			backgroundConnect	24	10	77	14	26	58
			firstReactRender	208	55	370	123	339	360
			getState	10	4	32	6	12	23
			initialActions	3	1	6	1	3	5
			loadScripts	1598	1294	1872	130	1705	1817
			setupStore	20	6	287	31	19	35
Firefox	Browserify	Home	uiStartup	1378	1181	1752	110	1450	1589
			load	1227	1040	1600	111	1291	1454
			domContentLoaded	1227	1040	1599	111	1291	1454
			domInteractive	103	38	188	31	121	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	197	23	21	57
			firstReactRender	24	20	56	6	24	35
			getState	7	4	36	3	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1205	1020	1581	107	1267	1407
			setupStore	8	4	185	18	6	8
	Webpack	Home	uiStartup	1496	1321	1860	118	1580	1738
			load	1279	1159	1596	97	1339	1464
			domContentLoaded	1278	1159	1596	97	1338	1464
			domInteractive	81	54	223	25	86	136
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	79	8	22	41
			firstReactRender	35	29	55	5	36	47
			getState	8	4	29	3	9	13
			initialActions	0	0	2	1	1	1
			loadScripts	1259	1143	1584	97	1325	1446
			setupStore	14	5	311	41	8	27

Bundle size diffs [🚀 Bundle size reduced!]

background: 161 Bytes (0%)
ui: 67 Bytes (0%)
common: -56.32 KiB (-0.6%)

sahar-fehri added 3 commits April 15, 2025 19:08

chore: integrate market data for solana

784449c

fix: remove local snap

870c6ec

fix: add fetch historical fct

a56242e

sahar-fehri changed the title ~~Chore/upgrade assets controllers~~ chore: upgrade assets controllers Apr 15, 2025

metamaskbot added the team-assets label Apr 15, 2025

sahar-fehri added 2 commits April 16, 2025 17:15

fix: bump snaps execution environments

de280e8

Merge branch 'main' into chore/upgrade-assets-controllers

7126240

sahar-fehri added 5 commits April 16, 2025 17:47

fix: cleanup

ae5c018

fix: cleanup

2d26c7e

fix: cleanup

6b286da

Merge branch 'main' into chore/upgrade-assets-controllers

d6bc91e

fix: upgrade to v58

a328639

sahar-fehri changed the title ~~chore: upgrade assets controllers~~ chore: upgrade assets controllers to v58.0.0 Apr 17, 2025

sahar-fehri added 2 commits April 17, 2025 14:40

fix: rm patch

a777490

fix: fix yarn

3286281

sahar-fehri added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 17, 2025

Update LavaMoat policies

82da38a

sahar-fehri marked this pull request as ready for review April 17, 2025 13:24

sahar-fehri requested review from a team as code owners April 17, 2025 13:24

Prithpal-Sooriya previously approved these changes Apr 17, 2025

View reviewed changes

fix: fix lint

1451aca

sahar-fehri dismissed Prithpal-Sooriya’s stale review via 1451aca April 17, 2025 13:54

sahar-fehri added 3 commits April 17, 2025 15:55

Merge branch 'main' into chore/upgrade-assets-controllers

b259177

fix: fix

6680737

fix: lint

a5393a5

sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Apr 17, 2025

sahar-fehri added 2 commits April 17, 2025 17:06

Merge branch 'main' into chore/upgrade-assets-controllers

4f2941a

Merge branch 'main' into chore/upgrade-assets-controllers

ea422ed

sahar-fehri enabled auto-merge April 17, 2025 16:38

Merge branch 'main' into chore/upgrade-assets-controllers

80d560b

Merge branch 'main' into chore/upgrade-assets-controllers

71735f2

gambinish approved these changes Apr 17, 2025

View reviewed changes

Prithpal-Sooriya approved these changes Apr 17, 2025

View reviewed changes

sahar-fehri added this pull request to the merge queue Apr 17, 2025

Merged via the queue into main with commit 36ae7c0 Apr 17, 2025
169 checks passed

sahar-fehri deleted the chore/upgrade-assets-controllers branch April 17, 2025 21:15

github-actions bot locked and limited conversation to collaborators Apr 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: upgrade assets controllers to v58.0.0 #32019

chore: upgrade assets controllers to v58.0.0 #32019

Uh oh!

sahar-fehri commented Apr 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

socket-security bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

sahar-fehri commented Apr 17, 2025

Uh oh!

sahar-fehri commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chore: upgrade assets controllers to v58.0.0 #32019

chore: upgrade assets controllers to v58.0.0 #32019

Uh oh!

Conversation

sahar-fehri commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

socket-security bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sahar-fehri commented Apr 17, 2025

Uh oh!

sahar-fehri commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

metamaskbot commented Apr 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sahar-fehri commented Apr 15, 2025 •

edited

Loading

socket-security bot commented Apr 16, 2025 •

edited

Loading

socket-security bot commented Apr 17, 2025 •

edited

Loading