Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Messenger } from '@metamask/base-controller';
import {
AccountsControllerAccountAddedEvent,
AccountsControllerGetSelectedMultichainAccountAction,
AccountsControllerListMultichainAccountsAction,
} from '@metamask/accounts-controller';
import {
Expand All @@ -19,7 +20,8 @@ type Actions =
| HandleSnapRequest
| AccountsControllerListMultichainAccountsAction
| GetCurrencyRateState
| MultichainAssetsControllerGetStateAction;
| MultichainAssetsControllerGetStateAction
| AccountsControllerGetSelectedMultichainAccountAction;

type Events =
| KeyringControllerLockEvent
Expand Down Expand Up @@ -56,6 +58,7 @@ export function getMultichainAssetsRatesControllerMessenger(
'SnapController:handleRequest',
'CurrencyRateController:getState',
'MultichainAssetsController:getState',
'AccountsController:getSelectedMultichainAccount',
],
});
}
6 changes: 6 additions & 0 deletions app/scripts/metamask-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -4212,6 +4212,12 @@ export default class MetamaskController extends EventEmitter {
tokenDetectionController,
),

// MultichainAssetsRatesController
fetchHistoricalPricesForAsset: (...args) =>
this.multichainAssetsRatesController.fetchHistoricalPricesForAsset(
...args,
),

// DetectCollectibleController
detectNfts: nftDetectionController.detectNfts.bind(
nftDetectionController,
Expand Down
38 changes: 2 additions & 36 deletions lavamoat/browserify/beta/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,7 @@
"clearTimeout": true,
"console.error": true,
"console.log": true,
"fetch": true,
"setInterval": true,
"setTimeout": true
},
Expand All @@ -1091,7 +1092,7 @@
"@metamask/metamask-eth-abis": true,
"@metamask/polling-controller": true,
"@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/snaps-utils": true,
"@metamask/snaps-utils": true,
"@metamask/utils": true,
"@metamask/name-controller>async-mutex": true,
"bn.js": true,
Expand Down Expand Up @@ -2207,41 +2208,6 @@
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/assets-controllers>@metamask/snaps-utils": {
"globals": {
"File": true,
"FileReader": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"console.error": true,
"console.log": true,
"console.warn": true,
"crypto": true,
"document.body.appendChild": true,
"document.createElement": true,
"fetch": true
},
"packages": {
"@metamask/snaps-sdk>@metamask/key-tree": true,
"@metamask/permission-controller": true,
"@metamask/rpc-errors": true,
"@metamask/snaps-utils>@metamask/slip44": true,
"@metamask/snaps-sdk": true,
"@metamask/utils>@metamask/superstruct": true,
"@metamask/utils": true,
"@noble/hashes": true,
"@metamask/utils>@scure/base": true,
"chalk": true,
"@metamask/snaps-utils>cron-parser": true,
"@metamask/snaps-utils>fast-json-stable-stringify": true,
"@metamask/snaps-utils>fast-xml-parser": true,
"@metamask/snaps-utils>marked": true,
"@metamask/snaps-utils>rfdc": true,
"semver": true,
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/bridge-controller>@metamask/snaps-utils": {
"globals": {
"File": true,
Expand Down
38 changes: 2 additions & 36 deletions lavamoat/browserify/flask/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,7 @@
"clearTimeout": true,
"console.error": true,
"console.log": true,
"fetch": true,
"setInterval": true,
"setTimeout": true
},
Expand All @@ -1091,7 +1092,7 @@
"@metamask/metamask-eth-abis": true,
"@metamask/polling-controller": true,
"@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/snaps-utils": true,
"@metamask/snaps-utils": true,
"@metamask/utils": true,
"@metamask/name-controller>async-mutex": true,
"bn.js": true,
Expand Down Expand Up @@ -2207,41 +2208,6 @@
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/assets-controllers>@metamask/snaps-utils": {
"globals": {
"File": true,
"FileReader": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"console.error": true,
"console.log": true,
"console.warn": true,
"crypto": true,
"document.body.appendChild": true,
"document.createElement": true,
"fetch": true
},
"packages": {
"@metamask/snaps-sdk>@metamask/key-tree": true,
"@metamask/permission-controller": true,
"@metamask/rpc-errors": true,
"@metamask/snaps-utils>@metamask/slip44": true,
"@metamask/snaps-sdk": true,
"@metamask/utils>@metamask/superstruct": true,
"@metamask/utils": true,
"@noble/hashes": true,
"@metamask/utils>@scure/base": true,
"chalk": true,
"@metamask/snaps-utils>cron-parser": true,
"@metamask/snaps-utils>fast-json-stable-stringify": true,
"@metamask/snaps-utils>fast-xml-parser": true,
"@metamask/snaps-utils>marked": true,
"@metamask/snaps-utils>rfdc": true,
"semver": true,
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/bridge-controller>@metamask/snaps-utils": {
"globals": {
"File": true,
Expand Down
38 changes: 2 additions & 36 deletions lavamoat/browserify/main/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,7 @@
"clearTimeout": true,
"console.error": true,
"console.log": true,
"fetch": true,
"setInterval": true,
"setTimeout": true
},
Expand All @@ -1091,7 +1092,7 @@
"@metamask/metamask-eth-abis": true,
"@metamask/polling-controller": true,
"@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/snaps-utils": true,
"@metamask/snaps-utils": true,
"@metamask/utils": true,
"@metamask/name-controller>async-mutex": true,
"bn.js": true,
Expand Down Expand Up @@ -2207,41 +2208,6 @@
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/assets-controllers>@metamask/snaps-utils": {
"globals": {
"File": true,
"FileReader": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"console.error": true,
"console.log": true,
"console.warn": true,
"crypto": true,
"document.body.appendChild": true,
"document.createElement": true,
"fetch": true
},
"packages": {
"@metamask/snaps-sdk>@metamask/key-tree": true,
"@metamask/permission-controller": true,
"@metamask/rpc-errors": true,
"@metamask/snaps-utils>@metamask/slip44": true,
"@metamask/snaps-sdk": true,
"@metamask/utils>@metamask/superstruct": true,
"@metamask/utils": true,
"@noble/hashes": true,
"@metamask/utils>@scure/base": true,
"chalk": true,
"@metamask/snaps-utils>cron-parser": true,
"@metamask/snaps-utils>fast-json-stable-stringify": true,
"@metamask/snaps-utils>fast-xml-parser": true,
"@metamask/snaps-utils>marked": true,
"@metamask/snaps-utils>rfdc": true,
"semver": true,
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/bridge-controller>@metamask/snaps-utils": {
"globals": {
"File": true,
Expand Down
38 changes: 2 additions & 36 deletions lavamoat/browserify/mmi/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1203,6 +1203,7 @@
"clearTimeout": true,
"console.error": true,
"console.log": true,
"fetch": true,
"setInterval": true,
"setTimeout": true
},
Expand All @@ -1222,7 +1223,7 @@
"@metamask/metamask-eth-abis": true,
"@metamask/polling-controller": true,
"@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/snaps-utils": true,
"@metamask/snaps-utils": true,
"@metamask/utils": true,
"@metamask/name-controller>async-mutex": true,
"bn.js": true,
Expand Down Expand Up @@ -2338,41 +2339,6 @@
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/assets-controllers>@metamask/snaps-utils": {
"globals": {
"File": true,
"FileReader": true,
"TextDecoder": true,
"TextEncoder": true,
"URL": true,
"console.error": true,
"console.log": true,
"console.warn": true,
"crypto": true,
"document.body.appendChild": true,
"document.createElement": true,
"fetch": true
},
"packages": {
"@metamask/snaps-sdk>@metamask/key-tree": true,
"@metamask/permission-controller": true,
"@metamask/rpc-errors": true,
"@metamask/snaps-utils>@metamask/slip44": true,
"@metamask/snaps-sdk": true,
"@metamask/utils>@metamask/superstruct": true,
"@metamask/utils": true,
"@noble/hashes": true,
"@metamask/utils>@scure/base": true,
"chalk": true,
"@metamask/snaps-utils>cron-parser": true,
"@metamask/snaps-utils>fast-json-stable-stringify": true,
"@metamask/snaps-utils>fast-xml-parser": true,
"@metamask/snaps-utils>marked": true,
"@metamask/snaps-utils>rfdc": true,
"semver": true,
"@metamask/snaps-utils>validate-npm-package-name": true
}
},
"@metamask/bridge-controller>@metamask/snaps-utils": {
"globals": {
"File": true,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@
"@metamask/address-book-controller": "^6.0.3",
"@metamask/announcement-controller": "^7.0.3",
"@metamask/approval-controller": "^7.0.0",
"@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A56.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-56.0.0-c5bff98e9b.patch",
"@metamask/assets-controllers": "patch:@metamask/assets-controllers@npm%3A58.0.0#~/.yarn/patches/@metamask-assets-controllers-npm-58.0.0-e574d55300.patch",
"@metamask/base-controller": "^8.0.0",
"@metamask/bitcoin-wallet-snap": "^0.9.0",
"@metamask/bridge-controller": "^11.0.0",
Expand Down
32 changes: 31 additions & 1 deletion ui/selectors/assets.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
getAssetsRates,
getMultiChainAssets,
getMultichainNativeAssetType,
getHistoricalPrices,
} from './assets';

const mockRatesState = {
Expand All @@ -19,6 +20,15 @@ const mockRatesState = {
'token-1': { rate: 1.5, currency: 'USD' },
'token-2': { rate: 0.8, currency: 'EUR' },
},
historicalPrices: {
'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501': {
usd: {
intervals: {},
updateTime: 1737542312,
expirationTime: 1737542312,
},
},
},
},
};

Expand Down Expand Up @@ -69,7 +79,7 @@ describe('getAssetsRates', () => {

it('should return an empty object if assetsRates is empty', () => {
const emptyState: AssetsRatesState = {
metamask: { conversionRates: {} },
metamask: { conversionRates: {}, historicalPrices: {} },
};
const result = getAssetsRates(emptyState);
expect(result).toEqual({});
Expand All @@ -81,6 +91,26 @@ describe('getAssetsRates', () => {
});
});

describe('getHistoricalPrices', () => {
it('should return the assetsRates from the state', () => {
const result = getHistoricalPrices(mockRatesState);
expect(result).toEqual(mockRatesState.metamask.historicalPrices);
});

it('should return an empty object if historicalPrices is empty', () => {
const emptyState: AssetsRatesState = {
metamask: { conversionRates: {}, historicalPrices: {} },
};
const result = getHistoricalPrices(emptyState);
expect(result).toEqual({});
});

it('should return undefined if state does not have metamask property', () => {
const invalidState = {} as AssetsRatesState;
expect(() => getHistoricalPrices(invalidState)).toThrow();
});
});

describe('getMultiChainAssets', () => {
const mockAccountId = '5132883f-598e-482c-a02b-84eeaa352f5b';
const mockMultichainBalances = {
Expand Down
10 changes: 10 additions & 0 deletions ui/selectors/assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ export function getAssetsRates(state: AssetsRatesState) {
return state.metamask.conversionRates;
}

/**
* Gets non-EVM assets historical prices.
*
* @param state - Redux state object.
* @returns An object containing non-EVM assets historical prices per asset types (CAIP-19).
*/
export function getHistoricalPrices(state: AssetsRatesState) {
return state.metamask.historicalPrices;
}

export const getTokenBalancesEvm = createDeepEqualSelector(
getTokensAcrossChainsByAccountAddressSelector,
getNativeTokenCachedBalanceByChainIdSelector,
Expand Down
1 change: 1 addition & 0 deletions ui/selectors/multichain.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ function getEvmState(chainId: Hex = CHAIN_IDS.MAINNET): TestState {
},
},
conversionRates: {},
historicalPrices: {},
assetsMetadata: {},
accountsAssets: {},
isEvmSelected: false,
Expand Down
Loading
Loading