-
Notifications
You must be signed in to change notification settings - Fork 5.4k
ci: update release artifacts creation #33601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [32d746c]
UI Startup Metrics (1258 ± 88 ms)
Benchmark value 1087 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1079 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 1421 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1234 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1228 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1227 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 977 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 45 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 79ms | Sum of p95 exceeds: 495ms Sum of all benchmark exceeds: 574ms Bundle size diffs
|
HowardBraham
approved these changes
Jun 11, 2025
Collaborator
Builds ready [a233ab6]
UI Startup Metrics (1208 ± 61 ms)
Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 307 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 11ms | Sum of p95 exceeds: 276ms Sum of all benchmark exceeds: 287ms Bundle size diffs
|
davidmurdoch
approved these changes
Jun 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables the PR checks for the master branch and enables the metamaskbot comment for release branches, even if there is a merge conflict.
Related issues
Fixes: #32582
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist