Skip to content

Conversation

@itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jun 11, 2025

Description

Open in GitHub Codespaces

This PR disables the PR checks for the master branch and enables the metamaskbot comment for release branches, even if there is a merge conflict.

Related issues

Fixes: #32582

Manual testing steps

  1. The main workflow should only run once on release branches and it should happen on push. PRs targeting master should not trigger PR checks.
  2. The metamaskbot comment should be posted on release branches when there is a PR from the release branch to master, even if there is a merge conflict.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Jun 11, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Jun 11, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Jun 11, 2025
@itsyoboieltr itsyoboieltr moved this from Needs dev review to Needs more work from the author in PR review queue Jun 11, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [32d746c]
UI Startup Metrics (1258 ± 88 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1258110815128813191421
load108796412888111501234
domContentLoaded107994912838311421227
domInteractive18147571729
firstPaint71682129244410961226
backgroundConnect94397926
firstReactRender22167282244
getState1665082130
initialActions001000
loadScripts828698101780893977
setupStore95384817
WebpackHomeuiStartup20701647252421422382412
load16101211193117217351854
domContentLoaded16041205192217117291845
domInteractive15117491336
firstPaint1606249461187259
backgroundConnect2412347332335
firstReactRender13643352107269339
getState184308421430
initialActions318135
loadScripts16011202191117017261833
setupStore4463138719305
FirefoxBrowserifyHomeuiStartup13861198205612014441597
load1223106815179412861375
domContentLoaded1223106715169412861374
domInteractive1053620730121168
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2514300312353
firstReactRender24215342428
getState11419721939
initialActions002001
loadScripts1202105314999212571352
setupStore9425125612
WebpackHomeuiStartup1496134617619615691671
load1294116515619013331463
domContentLoaded1294116515609013321463
domInteractive76542942979132
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21154342228
firstReactRender40305144347
getState12523624931
initialActions001011
loadScripts1275114715449113131448
setupStore85707812
Benchmark value 1259 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1087 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1079 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 1421 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1234 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1228 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1227 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 26 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 977 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 45 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 79ms | Sum of p95 exceeds: 495ms
Sum of all benchmark exceeds: 574ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@itsyoboieltr itsyoboieltr moved this from Needs more work from the author to Needs dev review in PR review queue Jun 11, 2025
@itsyoboieltr itsyoboieltr requested review from Gudahtt and HowardBraham and removed request for HowardBraham June 11, 2025 20:47
@HowardBraham HowardBraham changed the title fix: update release artifacts creation ci: update release artifacts creation Jun 11, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [a233ab6]
UI Startup Metrics (1208 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1208110113516112471339
load104694212025810871150
domContentLoaded103993311945910791140
domInteractive16133651631
firstPaint74468118540810641133
backgroundConnect84315821
firstReactRender20163632124
getState156100112026
initialActions001001
loadScripts79569394757833892
setupStore85223813
WebpackHomeuiStartup21321620256422722932484
load16611273200818018021920
domContentLoaded16551269200417917891911
domInteractive16125381440
firstPaint1546136451183257
backgroundConnect21134872438
firstReactRender13944427112274350
getState204339511431
initialActions317135
loadScripts16521267200017717801905
setupStore3963147820307
FirefoxBrowserifyHomeuiStartup1333119615777513711506
load1178105313917012171309
domContentLoaded1178105213907012171308
domInteractive993435443106164
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect211283112146
firstReactRender23204832327
getState11418524920
initialActions001001
loadScripts1159103013787111981294
setupStore74345614
WebpackHomeuiStartup14881305198511415651687
load12901134158110213781475
domContentLoaded12891133158110213781475
domInteractive75463263078115
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20146762028
firstReactRender39285534245
getState85294810
initialActions102111
loadScripts12721118156510313631460
setupStore12424931820
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2484 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 307 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 11ms | Sum of p95 exceeds: 276ms
Sum of all benchmark exceeds: 287ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 12, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2025
@itsyoboieltr itsyoboieltr added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 0ac1b9c Jun 12, 2025
154 checks passed
@itsyoboieltr itsyoboieltr deleted the fix/update-release-artifacts-creation branch June 12, 2025 18:08
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jun 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-extension-platform Extension Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Update release artifacts creation to run on push to release branch

5 participants