Skip to content

Conversation

@gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Aug 19, 2025

Description

I forgot to update github-tools commit sha in my previous PR merged a few minutes ago: #35194

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin self-assigned this Aug 19, 2025
@gauthierpetetin gauthierpetetin added the team-extension-platform Extension Platform team label Aug 19, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [7379994]
UI Startup Metrics (1159 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1159106113486112001294
load98387711605910141099
domContentLoaded97587211535910071083
domInteractive16134141723
firstPaint63277112939910011076
backgroundConnect2142012398218235
firstReactRender19133742130
getState1146181326
initialActions30234314
loadScripts76967394158800885
setupStore74182811
WebpackHomeuiStartup21641699268519322792485
load16241183196216217041893
domContentLoaded16171176194316016971879
domInteractive181190161467
firstPaint1746145168200297
backgroundConnect3212339443055
firstReactRender19884399110344379
getState2953157112276
initialActions52233512
loadScripts16131172193015916941867
setupStore206300491430
FirefoxBrowserifyHomeuiStartup13611155181211814231567
load1173101314838912241330
domContentLoaded1172101314838912241330
domInteractive993526744102212
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect321797153568
firstReactRender24196272430
getState62527516
initialActions5018418216
loadScripts114898914668611961292
setupStore835910635
WebpackHomeuiStartup16261393203112817141853
load13481158175811014231547
domContentLoaded13481158175811014231547
domInteractive95312824399192
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3720151233887
firstReactRender53416865866
getState125118141232
initialActions5111813322
loadScripts13201139173511214011526
setupStore11514716923
Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 235 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 30 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 2485 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 379 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 276 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 212 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1626 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 38 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 54 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 192 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 87 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 264ms | Sum of p95 exceeds: 515.8ms
Sum of all benchmark exceeds: 779.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 43 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@gauthierpetetin gauthierpetetin added this pull request to the merge queue Aug 19, 2025
Merged via the queue into main with commit baa6fb1 Aug 19, 2025
152 of 153 checks passed
@gauthierpetetin gauthierpetetin deleted the fix-create-release-pr branch August 19, 2025 09:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2025
@metamaskbot metamaskbot added the release-13.3.0 Issue or pull request that will be included in release 13.3.0 label Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.3.0 Issue or pull request that will be included in release 13.3.0 size-XS team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants