test: add Solana Websocket server by default in all our e2e cp-13.3.1 #36165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaona
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (2 files, +26 -24)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
seaona
commented
Sep 22, 2025
| server, | ||
| testSpecificMock, | ||
| { chainId, ethConversionInUsd = 1700 }, | ||
| withSolanaWebSocket, |
Member
Author
There was a problem hiding this comment.
not needed as param anymore, as we should always apply the wss mock now
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [7b2cf09]
UI Startup Metrics (1280 ± 76 ms)
Benchmark value 1101 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1094 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 225 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 877 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1428 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1238 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1234 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1224 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 238 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1016 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1476 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1277 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1276 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 38 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 31 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1247 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1701 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 269 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 91 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 46 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 321 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 11 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 596ms | Sum of p95 exceeds: 850.8ms Sum of all benchmark exceeds: 1446.8ms |
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [f654534]
UI Startup Metrics (1194 ± 60 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 223 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 215 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 88 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 9 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1624 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1385 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1385 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 295 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 55 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 276ms | Sum of p95 exceeds: 417.8ms Sum of all benchmark exceeds: 693.8ms |
javiergarciavera
approved these changes
Sep 22, 2025
cmd-ob
approved these changes
Sep 22, 2025
metamaskbot
added
the
release-13.5.0
gauthierpetetin
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the Solana websocket by default in all specs, and passes the default solana mocks.
It enables tests to pass custom solana websocket mocks too.
Previous related work:
Changelog
CHANGELOG entry:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1008
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist