test: fix flaky test " Multichain API Calling wallet_invokeMethod " #37390
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloeYue
added
e2e-test
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +10 -5)
👨🔧 @MetaMask/wallet-integrations (1 files, +1 -1)
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [accd542]
UI Startup Metrics (1244 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chloeYue
changed the title
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [c92f5cb]
UI Startup Metrics (1253 ± 77 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Oct 30, 2025
Contributor
|
LGTM ! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jiexi
approved these changes
Oct 30, 2025
metamaskbot
added
the
release-13.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reason for the test failure is that when calling
clickFooterConfirmButtonAndAndWaitForWindowToClose, the window does not close after clicking the confirm button. This behavior is correct, because multiple confirmation windows are open, the next test step checks the display of the next confirmation screen. Therefore, we should not useclickFooterConfirmButtonAndAndWaitForWindowToClose. The fix is to useclickFooterConfirmButtoninstead.Why the test was flaky instead of consistently failing? Because in the test spec, we use
ifconditions to check and confirm the confirmation screens. Since the send calls are triggered at the same time, the order in which the confirmation screens appear can vary. The test verifies the displayed information on confirmation screen regardless the screen order.If the flow goes into a different
ifblock, the test passes; however, if it follows this particularifblock, the test fails.I also improved the function
checkIsSenderAccountDisplayedto usewaitForSelectorto be more stable.I ran this test 10 times and they all passed.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Stabilizes multichain E2E by avoiding window-close waits during sequential confirmations and making sender-account checks wait-based.
test/e2e/flask/multichain-api/evm/wallet_invokeMethod.spec.ts)clickFooterConfirmButtonAndAndWaitForWindowToClosewithclickFooterConfirmButtonto proceed without waiting for the window to close when multiple dialogs are pending.test/e2e/page-objects/pages/confirmations/redesign/transaction-confirmation.ts)checkIsSenderAccountDisplayedmore robust by usingwaitForSelectorwith try/catch, returning a boolean after waiting for the sender account element.Written by Cursor Bugbot for commit c92f5cb. This will update automatically on new commits. Configure here.