Skip to content

test: fix flaky test " Multichain API Calling wallet_invokeMethod " #37390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HowardBraham merged 3 commits into from
Oct 30, 2025
+11 −6
Merged

test: fix flaky test " Multichain API Calling wallet_invokeMethod " #37390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
accd542
fix test
chloeYue Oct 30, 2025
3466214
update
chloeYue Oct 30, 2025
c92f5cb
update
chloeYue Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/flask/multichain-api/evm/wallet_invokeMethod.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ describe('Multichain API', function () {
await confirmation.clickFooterConfirmButtonAndAndWaitForWindowToClose();
} else {
await confirmation.checkNetworkIsDisplayed('Localhost 7777');
await confirmation.clickFooterConfirmButtonAndAndWaitForWindowToClose();
await confirmation.clickFooterConfirmButton();

// third confirmation page should display Account 2 as sender account
await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog);
Expand Down
15 changes: 10 additions & 5 deletions test/e2e/page-objects/pages/confirmations/redesign/transaction-confirmation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,18 @@ class TransactionConfirmation extends Confirmation {
console.log(
`Checking sender account ${account} on transaction confirmation page.`,
);
return await this.driver.isElementPresentAndVisible(
{
try {
await this.driver.waitForSelector({
css: this.senderAccount,
text: account,
},
2000,
);
});
return true;
} catch (err) {
console.log(
`Sender account ${account} is not displayed on transaction confirmation page.`,
);
return false;
}
}

/**
Expand Down