feat: price API v3 upgrade #37741
Merged
feat: price API v3 upgrade #37741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [1b01012]
UI Startup Metrics (1234 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergarces
force-pushed
the
prices-v3-upgrade
branch
from
1b01012 to
2bc2dc4
Compare
Collaborator
Builds ready [2bc2dc4]
UI Startup Metrics (1217 ± 81 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bfcc40a]
UI Startup Metrics (1242 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [14efbd0]
UI Startup Metrics (1235 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergarces
force-pushed
the
prices-v3-upgrade
branch
from
df6d02e to
d784cd9
Compare
bergarces
commented
Nov 16, 2025
Contributor
Author
There was a problem hiding this comment.
There changes should not affect anything. This hook is used purely to start polling, the return result is not used and therefore it is not needed.
Collaborator
Builds ready [85dbc1a]
UI Startup Metrics (1251 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergarces
commented
Nov 26, 2025
| + '0x82750': null, //'eip155:534352/slip44:60', // Scroll Mainnet - Native symbol: ETH | ||
| + '0x4e454152': null, //'eip155:60/slip44:60', // Aurora Mainnet (Ethereum L2 on NEAR) - Native symbol: ETH | ||
| + '0x63564c40': null, //'eip155:1666600000/slip44:1023', // Harmony Mainnet Shard 0 - Native symbol: ONE | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Setting them to null falls back to v2. When the API is fixed we can remove this part of the patch.
bergarces
commented
Nov 26, 2025
| return []; | ||
| } | ||
| - const url = new URL(`${BASE_URL_V2}/chains/${chainId}/spot-prices`); | ||
| + const url = new URL(`${BASE_URL_V2}/chains/${parseInt(chainId, 16)}/spot-prices`); |
Contributor
Author
There was a problem hiding this comment.
It works both with decimal and hexadecimal, but all the e2e tests are mocked using decimal, so this is easier than changing all of them.
When we remove the fallback to v2 they'll have to be changed anyway.
Collaborator
Builds ready [49381b2]
UI Startup Metrics (1327 ± 144 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [0c67149]
UI Startup Metrics (1327 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
previously approved these changes
Nov 26, 2025
micaelae
previously approved these changes
Nov 26, 2025
bergarces
dismissed stale reviews from micaelae and Prithpal-Sooriya
via
72dc005
Prithpal-Sooriya
approved these changes
Nov 27, 2025
Collaborator
Builds ready [72dc005]
UI Startup Metrics (1299 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [11888a4]
UI Startup Metrics (1267 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [bd06391]
UI Startup Metrics (1227 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
salimtb
approved these changes
Nov 28, 2025
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade assets-controllers to start using Price API v3 spot-prices endpoint.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-1575
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Upgrades @metamask/assets-controllers to v91 with spot-prices v3 tweaks (decimal chainId, added MON currency), normalizes account casing in balance updates, simplifies token rates messaging/polling, adds a selector variant for Tron resources, and updates LavaMoat policies.
@metamask/assets-controllerstov91.0.0(patched); update related locks and@metamask/controller-utils/@metamask/polling-controllerversions.montoSUPPORTED_CURRENCIES./spot-pricesURL (parseInt(chainId, 16)).SPOT_PRICES_SUPPORT_INFOmappings (many set tonull).TokenBalancesController, lower-caseaccountkeys when reading/writingtokenBalances.TokensController:getStateandNetworkController:getStateand corresponding state-change events.useTokenRatesPollingto only manage polling (no returned state).getAssetsBySelectedAccountGroupnow directly proxies toselectAssetsBySelectedAccountGroup.getAssetsBySelectedAccountGroupWithTronResources(passes{ filterTronStakedTokens: false }); update tests accordingly.@metamask/assets-controllers>@metamask/polling-controllerand add a new policy block.Written by Cursor Bugbot for commit bd06391. This will update automatically on new commits. Configure here.