-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: price API v3 upgrade #37741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: price API v3 upgrade #37741
Changes from all commits
47d40bd
2bc2dc4
5e1e68c
5415086
b136954
51cef17
bfcc40a
7ea12be
f48f679
14efbd0
d784cd9
85dbc1a
79e59ca
04f693d
76bb5ef
de8b20d
e4f2518
10d085e
8dff078
3b468b4
b77709b
d7efa5a
6dc4e0a
099cfa7
69188a8
671deb1
91a77c6
e51ad33
a9c0bac
819739b
d563bb5
d25c844
95fdf3f
d30a473
b5e678c
72877b1
bcbfeba
0e52615
6204d01
13dd55d
6a387ca
6d07c22
252fc5e
831ebf2
245d9e7
71e0bcf
363b3dc
d6cc6a1
fc75cbd
c31ad59
84a7b3c
49bb3d3
de59e54
4ba2ba5
15e0b76
570f73a
7d518d2
da4a197
515ce7b
1945f40
11ca89b
89a2b4d
b9e84f9
49381b2
bc1d518
813c037
0c67149
72dc005
11888a4
bd06391
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Large diffs are not rendered by default.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,5 @@ | ||
| import { useSelector } from 'react-redux'; | ||
| import { | ||
| getChainIdsToPoll, | ||
| getMarketData, | ||
| getTokenExchangeRates, | ||
| getTokensMarketData, | ||
| getUseCurrencyRateCheck, | ||
| } from '../selectors'; | ||
| import { getChainIdsToPoll, getUseCurrencyRateCheck } from '../selectors'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: useTokenRatesPolling hook missing return statementThe |
||
| import { getEnabledChainIds } from '../selectors/multichain/networks'; | ||
| import { | ||
| tokenRatesStartPolling, | ||
|
|
@@ -26,11 +20,6 @@ const useTokenRatesPolling = () => { | |
| const chainIds = useSelector(getChainIdsToPoll); | ||
| const enabledChainIds = useSelector(getEnabledChainIds); | ||
|
|
||
| // Selectors returning state updated by the polling | ||
| const tokenExchangeRates = useSelector(getTokenExchangeRates); | ||
| const tokensMarketData = useSelector(getTokensMarketData); | ||
| const marketData = useSelector(getMarketData); | ||
|
|
||
| const enabled = completedOnboarding && isUnlocked && useCurrencyRateCheck; | ||
|
|
||
| const pollableChains = isGlobalNetworkSelectorRemoved | ||
|
|
@@ -44,12 +33,6 @@ const useTokenRatesPolling = () => { | |
| stopPollingByPollingToken: tokenRatesStopPollingByPollingToken, | ||
| input: enabled ? [pollableChains] : [], | ||
| }); | ||
|
|
||
| return { | ||
| tokenExchangeRates, | ||
| tokensMarketData, | ||
| marketData, | ||
| }; | ||
| }; | ||
|
|
||
| export default useTokenRatesPolling; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There changes should not affect anything. This hook is used purely to start polling, the return result is not used and therefore it is not needed.