feat: : cp-13.10.0 added sidepanel icon #37777
Merged
+51
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +31 -29)
🎨 @MetaMask/design-system-engineers (1 files, +2 -0)
|
Collaborator
Builds ready [3cd6ad5]
UI Startup Metrics (1226 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
AndyMBridges
previously approved these changes
Nov 13, 2025
AndyMBridges
left a comment
AndyMBridges
left a comment
There was a problem hiding this comment.
@NidhiKJha Should we also update the popup icon in this PR?
ameliejyc
previously approved these changes
Nov 13, 2025
Collaborator
Builds ready [5af1b52]
UI Startup Metrics (1224 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
dismissed stale reviews from AndyMBridges and ameliejyc
via
4535e0a
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [4535e0a]
UI Startup Metrics (1232 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ameliejyc
reviewed
Nov 13, 2025
ameliejyc
previously approved these changes
Nov 13, 2025
Collaborator
Builds ready [c8dadac]
UI Startup Metrics (1228 ± 90 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
ameliejyc
dismissed stale reviews from AndyMBridges and themself
via
576d0e1
ameliejyc
approved these changes
Nov 13, 2025
n3ps
approved these changes
Nov 13, 2025
|
Already fixed |
Collaborator
Builds ready [576d0e1]
UI Startup Metrics (1203 ± 76 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
AndyMBridges
approved these changes
Nov 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Builds ready [592283c]
UI Startup Metrics (1254 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
This PR is to add sidepanel/popup icon to the DS component library. It also fixes an edge case with the Advanced Settings `Show extension in full-size view` button where users who have turned sidepanel on after enabling this will see sidepanel by default. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry:null ## **Related issues** Fixes: [https://consensyssoftware.atlassian.net/browse/CEUX-684](https://consensyssoftware.atlassian.net/browse/CEUX-684) ) ## **Manual testing steps** 1. In storybook, check sidepanel icon 2. Go to popup view or sidepanel and check the icon in global menu ## **Screenshots/Recordings** ### **Before** NA ### **After** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. -->   ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds popup/sidepanel icons to the design system, uses them for the view toggle in the global menu, and enables the full-size opening behavior from sidepanel too. > > - **Design System / Icons**: > - Add `app/images/icons/popup.svg` and `app/images/icons/sidepanel.svg`. > - Expose `IconName.Popup` and `IconName.Sidepanel` in `ui/components/component-library/icon/icon.types.ts`. > - **Global Menu** (`ui/components/multichain/global-menu/global-menu.tsx`): > - Replace viewport toggle to use `IconName.Popup`/`IconName.Sidepanel` and `isSidePanelDefault` logic; update metrics payload and close behavior. > - Add divider after notifications section. > - **Routing / Behavior** (`ui/pages/routes/routes.component.tsx`): > - Extend "Show extension in full-size view" to trigger when in `ENVIRONMENT_TYPE_SIDEPANEL` as well as popup. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 592283c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: ameliejyc <amelie.chan@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.11.0
NidhiKJha
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add sidepanel/popup icon to the DS component library.
It also fixes an edge case with the Advanced Settings
Show extension in full-size viewbutton where users who have turned sidepanel on after enabling this will see sidepanel by default.Changelog
CHANGELOG entry:null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-684
)
Manual testing steps
Screenshots/Recordings
Before
NA
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds popup/sidepanel icons to the design system, uses them for the view toggle in the global menu, and enables the full-size opening behavior from sidepanel too.
app/images/icons/popup.svgandapp/images/icons/sidepanel.svg.IconName.PopupandIconName.Sidepanelinui/components/component-library/icon/icon.types.ts.ui/components/multichain/global-menu/global-menu.tsx):IconName.Popup/IconName.SidepanelandisSidePanelDefaultlogic; update metrics payload and close behavior.ui/pages/routes/routes.component.tsx):ENVIRONMENT_TYPE_SIDEPANELas well as popup.Written by Cursor Bugbot for commit 592283c. This will update automatically on new commits. Configure here.