-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: add event for hide token #38358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+38
−15
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
366035f
chore: add event for hide token
sahar-fehri 666c4df
Merge branch 'main' into chore/add-tracing-for-hide-token
sahar-fehri ff07f37
Merge branch 'main' into chore/add-tracing-for-hide-token
sahar-fehri 247e105
Merge branch 'main' into chore/add-tracing-for-hide-token
sahar-fehri 11e465c
Merge branch 'main' into chore/add-tracing-for-hide-token
salimtb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hardcoded ERC20 token standard ignores ERC721 tokens
The
token_standardin theTokenHiddenevent is hardcoded asTokenStandard.ERC20, but thetokenobject can also represent ERC721 tokens (it has anisERC721property). When users hide an ERC721 token, the event will incorrectly report it as ERC20, causing inaccurate analytics data. The token standard could be determined dynamically usingtoken?.isERC721sinceTokenStandard.ERC721is available in the same imported enum.