Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the retry button on latest tx of earliest nonce. #4926

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jul 31, 2018

Fixes a minor issue with the logic for when retry buttons should be displayed on transactions.

The retry button is now only ever shown on the latest submitted transaction that shares a nonce with the earliest submitted transaction.

For example:

  • I creates Tx 1A, then creates Tx 2A.
  • both take too long, so the retry button will appear on Tx 1A
  • I retry Tx 2A first and create Tx 2B. The retry button will still only appear on Tx 1A
  • I now retry Tx 1A to create Tx 1B. Once Tx 1B takes too long, the retry button will appear on Tx 1B.

peek 2018-07-31 16-59

@danjm danjm requested review from alextsg and estebanmino July 31, 2018 19:37
@danjm danjm requested a review from whymarrh as a code owner July 31, 2018 19:37
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants