Get nonce for showing retry button using ethQuery transaction count. #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
force-pushed
the
nonce-for-retry-from-ethquery
branch
from
6bbac40 to
e98c3b4
Compare
whymarrh
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4974
The earliest submitted transaction is now decided by comparing nonces to the selected addresses transaction count as returned by
ethQuery.getTransactionCount. (See https://web3js.readthedocs.io/en/1.0/web3-eth.html#gettransactioncount)This handles the case where a user might have an old transaction that was resubmitted by some means outside of Metamask (e.g. my ether wallet) and then confirmed. Metamask would still recognize the transaction as 'submitted', causing the retry button to appear on the wrong transaction history list item.