Fix rounding issue when sending max tokens #5695
Conversation
alextsg
force-pushed
the
i5682-rounding
branch
2 times, most recently
from
9d20640 to
27738ee
Compare
| const tokenBalanceAmount = await findElement(driver, By.css('.transaction-view-balance__token-balance')) | ||
| assert.equal(await tokenBalanceAmount.getText(), '43 TST') | ||
| const tokenBalanceAmount = await findElement(driver, By.css('.transaction-view-balance__primary-balance')) | ||
| assert.equal(await tokenBalanceAmount.getText(), '43\nTST') |
There was a problem hiding this comment.
We could use \s here in a regular expression, similar to how we have below:
await driver.wait(until.elementTextMatches(balance, /0\s*BAT/))| toDenomination: denomination, | ||
| }) | ||
|
|
||
| displayValue = propsDisplayValue || formatCurrency(convertedValue, toCurrency) |
There was a problem hiding this comment.
If we inline convertedValue could we write this as a single cost displayValue statement without the conditional?
alextsg
force-pushed
the
i5682-rounding
branch
2 times, most recently
from
494f19b to
3536bde
Compare
| @@ -11,6 +11,9 @@ import { | |||
| import SendHeader from './send-header/' | |||
| import SendContent from './send-content/' | |||
| import SendFooter from './send-footer/' | |||
| import BigNumber from 'bignumber.js' | |||
|
|
|||
| window.BigNumber = BigNumber | |||
There was a problem hiding this comment.
why do we need to put BigNumber on window? I'm guess this was just for local development/testing purposes?
alextsg
force-pushed
the
i5682-rounding
branch
from
3536bde to
48d9ad7
Compare
|
I made a PR against this branch to fix a minor issue: alextsg#2 |
|
QA'd. All looks good. As a separate issue, we may want to deal with cases with a lot of significant digits on the confirm screen
|
|
@danjm Merged your PR and noticed that tests were failing due to number inputs. Why was it necessary to remove the |
|
Fixes #5180. |
alextsg
force-pushed
the
i5682-rounding
branch
from
573d1c2 to
23ae1a4
Compare
Fixes #5682