Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure amount row shows exact amount of max tokens on send screen #2

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Ensure amount row shows exact amount of max tokens on send screen #2

merged 1 commit into from
Nov 12, 2018

Conversation

danjm
Copy link

@danjm danjm commented Nov 11, 2018

Before:

screenshot from 2018-11-11 19-20-56

After:

screenshot from 2018-11-11 19-20-24

@danjm danjm requested a review from alextsg as a code owner November 11, 2018 22:57
@danjm danjm mentioned this pull request Nov 11, 2018
Merged
@alextsg alextsg merged commit bc1edc8 into alextsg:i5682-rounding Nov 12, 2018
@whymarrh whymarrh deleted the patch-1-rounding-token-input branch November 13, 2018 16:05
alextsg added a commit that referenced this pull request Dec 5, 2018
@alextsg
Fix rounding issue when sending max tokens (MetaMask#5695)
4c87c05 
* Fix rounding issue when sending max tokens

* Ensure amount row shows exact amount of max tokens on send screen (#2)

* Fix tests

* Change stored redux value from BigNumber to hex string. Fix TokenInput default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextsg alextsg Awaiting requested review from alextsg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danjm @alextsg