Refactor notification manager and triggerUi to use extension platform #8317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
changed the title
Gudahtt
force-pushed
the
refactor-notification-manager
branch
from
8b42fc0 to
fff264c
Compare
Builds ready [fff264c]
Page Load Metrics (602 ± 37 ms)
|
The notification manager has been refactored to use the extension platform module instead of using `extensionizer` directly. The extension platform API presents a more ergonomic API, and it correctly handles errors (which the old notification manager did not). Methods that the extension platform lacked have been added. It has been updated to use `async/await` instead of callbacks as well, for readability. The `triggerUI` function has also been updated to use the extension platform instead of `extensionizer`.
Gudahtt
force-pushed
the
refactor-notification-manager
branch
from
fff264c to
6237c68
Compare
Builds ready [6237c68]
Page Load Metrics (561 ± 38 ms)
|
whymarrh
reviewed
Apr 10, 2020
The platform is now accessible via the `platform` instance variable within the notification manager.
Builds ready [5bc39b9]
Page Load Metrics (686 ± 19 ms)
|
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notification manager has been refactored to use the extension platform module instead of using
extensionizerdirectly. The extension platform API presents a more ergonomic API, and it correctlyhandles errors (which the old notification manager did not). Methods that the extension platform lacked have been added.
It has been updated to use
async/awaitinstead of callbacks as well, for readability.The
triggerUIfunction has also been updated to use the extension platform instead ofextensionizer.