Focus the notification popup if it's already open #8318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
refactor-notification-manager
branch
from
8b42fc0 to
fff264c
Compare
Gudahtt
force-pushed
the
focus-popup-if-already-open
branch
from
d24060e to
7b41506
Compare
Gudahtt
force-pushed
the
refactor-notification-manager
branch
from
fff264c to
6237c68
Compare
Gudahtt
force-pushed
the
focus-popup-if-already-open
branch
from
7b41506 to
ec2f9d7
Compare
Builds ready [ec2f9d7]
Page Load Metrics (623 ± 30 ms)
|
Any action in the background that would have opened the notification window will now focus the window instead if it was already open. Previously it would leave the window unfocused. This was particularly inconvenient when taking multiple actions in quick succession that all require confirmations (e.g. triggering multiple transactions).
Gudahtt
force-pushed
the
focus-popup-if-already-open
branch
from
ec2f9d7 to
bd7bee7
Compare
Builds ready [bd7bee7]
Page Load Metrics (615 ± 31 ms)
|
wizzfile
added a commit
to wizzfile/metamask-extension
that referenced
this pull request
Apr 12, 2020
)" This reverts commit e02a022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any action in the background that would have opened the notification window will now focus the window instead if it was already open. Previously it would leave the window unfocused. This was particularly inconvenient when taking multiple actions in quick succession that all require confirmations (e.g. triggering multiple transactions).