Refactor token selectors #8671
Merged
Refactor token selectors #8671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused token selectors have been removed, and the remaining token selector has been moved to the `metamask` Redux store.
Gudahtt
force-pushed
the
refactor-token-selectors
branch
from
88fcfdb to
49066f3
Compare
rekmarks
reviewed
May 28, 2020
Builds ready [49066f3]
Page Load Metrics (611 ± 53 ms)
|
|
I would like selectors to live alongside the Redux stores they select from, as in the new alert stores. Co-locating the selectors with the store itself encapsulates knowledge of the state shape to this single module. Ideally all of our stores would behave this way: self-contained state-machines that control their own state (except the Selectors will likely still have to exist in other places as well, to perform post-processing specific to certain areas of the UI, or to combine data from different stores, but those can be built up from the store selectors without them needing to understand the internal store structure. |
Gudahtt
added a commit
that referenced
this pull request
Jun 1, 2020
* origin/develop: (689 commits) Implement asset page (#8696) fix crash on signature request (#8709) Fix accounts menu styling (#8707) Delete docs/porting_to_new_environment.md (#8704) Remove unused `getToErrorObject` parameters (#8705) hide connected-status on metamask ext (#8703) Stop adding permissions middleware to trusted connections (#8701) Use `send` state for send flow token (#8695) do not display extension id in connection modal (#8699) Fix tab content disappearing during scrolling on macOS Firefox (#8702) close details when button is pressed (#8694) Refactor token selectors (#8671) Update eth_accounts permission description (#8693) Extract selected token from token input (#8692) Fix propType for Home defaultHomeActiveTabName (#8683) Fix create account form styling (#8689) Remove unused `getSelectedTokenAssetImage` selector (#8691) Remove `getTxParams` (#8676) do not show account mismatch alert on details (#8678) Fix connect hardware styling (#8680) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused token selectors have been removed, and the remaining token selector has been moved to the
metamaskRedux store.