close details when button is pressed

[brad-decker]

Button behavior was broken by redesign work. Updated the details view to first call the onRetry or onCancel props and pass in the click event which it expect, then call the onClose prop to close the popover so that there aren't two modal-like experiences active at the same time. This behavior will be updated when we do the details redesign.

fixes #8684

[metamaskbot]

Builds ready [d35dd57]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (650 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	86	41	15	7
		domContentLoaded	438	755	648	61	29
		load	440	756	650	61	29
		domInteractive	438	755	648	61	29

[rekmarks]

What became of all the transactionGroup stuff?

[brad-decker]

@rekmarks its now encapsulated in the transaction-list-item file, which calls useRetryTransaction and useCancelTransaction .. its no longer necessary to pass in a transaction id.

[brad-decker]

metamask-extension/ui/app/hooks/useRetryTransaction.js

Lines 37 to 59 in 88bed71

	const retryTransaction = useCallback(async (event) => {
	event.stopPropagation()
	trackMetricsEvent()
	const basicEstimates = await dispatch(fetchBasicGasAndTimeEstimates)
	await dispatch(fetchGasEstimates(basicEstimates.blockTime))
	const transaction = initialTransaction
	const increasedGasPrice = increaseLastGasPrice(gasPrice)
	dispatch(setCustomGasPriceForRetry(increasedGasPrice || transaction.txParams.gasPrice))
	dispatch(setCustomGasLimit(transaction.txParams.gas))
	dispatch(showSidebar({
	transitionName: 'sidebar-left',
	type: 'customize-gas',
	props: { transaction },
	}))
	if (
	methodName === TOKEN_METHOD_TRANSFER &&
	initialTransaction.txParams.to
	) {
	dispatch(setSelectedToken(initialTransaction.txParams.to))
	}
	}, [dispatch, methodName, trackMetricsEvent, initialTransaction, gasPrice])

[rekmarks]

LGTM!