_checkIfTxWasDropped nextworkNextNonce type correction #8827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No radix-16 needed for nonce, already done, and BN doesn't need to be radix, returns number.
Builds ready [efd9c0d]
Page Load Metrics (662 ± 44 ms)
|
|
I don't understand, why isn't this needed/correct? |
|
parseInt(0x18, 16) !== parseInt('0x18', 16) edit |
|
I think the problem here is that This also explains why I wasn't able to reproduce the problem - my transaction count was below 10, so the base-10 and base-16 numbers were equivalent. |
Gudahtt
reviewed
Jun 17, 2020
…ify on networkNonce before parseInt.
tmashuang
changed the title
Gudahtt
reviewed
Jun 17, 2020
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
tmashuang
changed the title
Gudahtt
dismissed
their stale review
Ah, unit test failures. It looks like the stub was returning a string, when it should have been returning a BN
Gudahtt
reviewed
Jun 17, 2020
test/unit/app/controllers/transactions/pending-tx-tracker-test.js
Outdated
Show resolved
Hide resolved
whymarrh
reviewed
Jun 17, 2020
Builds ready [65f8e0e]
Page Load Metrics (734 ± 31 ms)
|
Gudahtt
previously approved these changes
Jun 17, 2020
Gudahtt
previously approved these changes
Jun 17, 2020
Gudahtt
approved these changes
Jun 17, 2020
Builds ready [fd435ec]
Page Load Metrics (1165 ± 88 ms)
|
tmashuang
changed the title
Gudahtt
added a commit
that referenced
this pull request
Jun 23, 2020
* origin/develop: Fix signing method bugs (#8833) replace icons with Checkbox component (#8830) Use gulp-cli@2.3.0 (#8845) Use node-sass@4.14.1 (#8844) Call getMethodDataAsync when knownMethodData[fourBytePrefix] object is empty (#8836) Update connected status popover content (#8834) Use @metamask/controllers@2.0.1 (#8832) ParseInt nextworkNextNonce correction (#8827) Fix first time onboarding popup position (#8829) fix overflowing contract names and origins (#8823) Hide 'Expand view' button in fullscreen (#8826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No radix-16 needed for nonce, already done,. NextNetworkNonce BN doesn't need it either, returns number when parsed.Stringify on networkNonce before parseInt.Just remove radix-16 on nextNetworkNonce.Radix-10 on nextworkNextNonce BN.networkNextNonce.toNumber()
Fixes #8688.