Fix first time onboarding popup position #8829
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connected status indicator had been moved left since this popup was first written. The position of the highlighted portion of the background has been updated reflect this.
Screenshots:Before:
After:
The width is still off, but we can't easily know the width because it depends upon whether the current tab is connected or not, and it depends upon the locale. |
Builds ready [6326c0d]
Page Load Metrics (825 ± 51 ms)
|
whymarrh
approved these changes
Jun 17, 2020
Gudahtt
added a commit
that referenced
this pull request
Jun 23, 2020
* origin/develop: Fix signing method bugs (#8833) replace icons with Checkbox component (#8830) Use gulp-cli@2.3.0 (#8845) Use node-sass@4.14.1 (#8844) Call getMethodDataAsync when knownMethodData[fourBytePrefix] object is empty (#8836) Update connected status popover content (#8834) Use @metamask/controllers@2.0.1 (#8832) ParseInt nextworkNextNonce correction (#8827) Fix first time onboarding popup position (#8829) fix overflowing contract names and origins (#8823) Hide 'Expand view' button in fullscreen (#8826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connected status indicator had been moved left since this popup was first written. The position of the highlighted portion of the background has been updated reflect this.