Fix account tracker optimization #8936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An optimization in `account-tracker.js` was being skipped consistently due to a type error (a number was being compared to a string). The optimization in this case was to update the balances for all accounts with a single request, rather than one request per account.
Builds ready [4c9f306]
Page Load Metrics (867 ± 53 ms)
|
brad-decker
approved these changes
Jul 7, 2020
|
Ah, it looks like this was broken recently, in #8627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optimization in
account-tracker.jswas being skipped consistently due to a type error (a number was being compared to a string).The optimization in this case was to update the balances for all accounts with a single request, rather than one request per account.