Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v8.0.4 RC #8937

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Version v8.0.4 RC #8937

merged 7 commits into from
Jul 8, 2020

Conversation

metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Jul 7, 2020 •
edited by Gudahtt
Loading

  • #8934: Fix transaction activity on custom networks
  • #8936: Fix account tracker optimization

Gudahtt and others added 6 commits July 6, 2020 17:46
@Gudahtt
Merge pull request #8931 from MetaMask/master
472ee89 
Sync `master` with `develop`
@brad-decker
add support for nullish coalescing (#8935)
14416a7
@tmashuang
Standardize transaction activity conversion's currency to 'ETH' (#8934)
15d713f
@Gudahtt
Fix account tracker optimization (#8936)
429af23 
An optimization in `account-tracker.js` was being skipped consistently
due to a type error (a number was being compared to a string).

The optimization in this case was to update the balances for all
accounts with a single request, rather than one request per account.
@danjm
Move checkExistingAddresses to helpers/utils/util and stop its use of…
ac52557 
… ramda (#8868)
@metamaskbot
Version v8.0.4
015008c
@metamaskbot metamaskbot requested a review from a team as a code owner July 7, 2020 22:29
@Gudahtt Gudahtt marked this pull request as draft July 7, 2020 22:53
@metamaskbot
Copy link
Collaborator Author

Builds ready [015008c]
Page Load Metrics (569 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3290492010
domContentLoaded33369056712560
load33769156912560
domInteractive33369056712560

@Gudahtt Gudahtt marked this pull request as ready for review July 8, 2020 00:11
@metamaskbot
Copy link
Collaborator Author

Builds ready [5213e9e]
Page Load Metrics (796 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34101652311
domContentLoaded45891279310751
load46091379610751
domInteractive45791179310751

@Gudahtt Gudahtt merged commit 5a3ae85 into master Jul 8, 2020
@Gudahtt Gudahtt deleted the Version-v8.0.4 branch July 8, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmashuang tmashuang tmashuang approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metamaskbot @Gudahtt @tmashuang @brad-decker @danjm