Hide gas estimate on non-main network #9189
Merged
+31
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Patryk 👋 To get the e2e tests passing, I think we're going need to ensure that the |
|
Mind rebasing this on the latest |
PatrykLucka
force-pushed
the
hide-advance-gas-on-non-mainnet
branch
from
68bcaaa to
af8b4be
Compare
rekmarks
reviewed
Aug 14, 2020
ui/app/pages/send/send-content/send-gas-row/send-gas-row.component.js
Outdated
Show resolved
Hide resolved
rekmarks
previously approved these changes
Aug 14, 2020
rekmarks
approved these changes
Aug 14, 2020
rekmarks
requested changes
Aug 14, 2020
There was a problem hiding this comment.
@PatrykLucka upon review, I'm afraid I've failed to give you good advice on this PR. I'm sorry for the back-and-forth.
We should not set the feature flag in order to implement this behavior. Rather, we should do this:
- If the network is Mainnet, the advanced gas controls showed be shown instead of the gas estimation only if the
advancedInlineGasfeature flag is set totrue. - If the network is not Mainnet, we should show the advanced gas controls, regardless of the state of the
advancedInlineGasfeature flag.- Unless we're in a test, in which case we should show the gas estimate.
- We should only override the feature flag in tests if we have to. I think it's possible that we can leave it alone, and just make all networks behave like Mainnet in tests.
- Unless we're in a test, in which case we should show the gas estimate.
Gudahtt
reviewed
Aug 14, 2020
|
Makes sense, thanks! |
…nent.js Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
PatrykLucka
force-pushed
the
hide-advance-gas-on-non-mainnet
branch
from
4222c28 to
1f2c57e
Compare
rekmarks
reviewed
Aug 17, 2020
Gudahtt
requested changes
Aug 18, 2020
...ponents/app/gas-customization/gas-modal-page-container/gas-modal-page-container.container.js
Outdated
Show resolved
Hide resolved
ui/app/pages/confirm-transaction-base/confirm-transaction-base.component.js
Outdated
Show resolved
Hide resolved
…cka/metamask-extension into hide-advance-gas-on-non-mainnet
Gudahtt
pushed a commit
that referenced
this pull request
Aug 19, 2020
* hide advance gas on non mainnet * hide edit gas button on non mainnet
Gudahtt
added a commit
that referenced
this pull request
Aug 19, 2020
The changelog has been updated to include #9189
Gudahtt
added a commit
that referenced
this pull request
Aug 19, 2020
* Hide gas estimate on non-main network (#9189) * Update v8.0.9 changelog
Merged
Gudahtt
added a commit
that referenced
this pull request
Aug 19, 2020
* origin/develop: (137 commits) Use @metamask/eslint-config@3.1.0 (#9275) Standardize scss import practices (#9183) Update ESLint shared config to v3 (#9274) Add lock icon to default networks (#9269) Adds toPrecisionWithoutTrailingZeros utility (#9270) Hide gas estimate on non-main network (#9189) Move the mascot component to its own directory (#9272) Use @metamask/controllers@2.0.5 (#9266) Fix padding, alignment of actionable-message; add left aligned story Code cleanup and simplification for actionable-message component Adds actionable message component and stories Fix lint issues (#9265) Fix prefer-destructuring issues (#9263) colocate confirm-decrypt-message page styles (#9252) Tidy up Migrator tests (#9264) Adds pulse loader component (#9259) Fix import/order issues (#9239) Fix radix issues (#9247) New info tooltip component (#9180) Improve scss naming ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes advanced gas settings option and three-button gas input (slow, average, fast) and shows the gas fields instead on all non-main networks.
Fixes: #9106