Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colocate confirm-decrypt-message page styles #9252

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

brad-decker
Copy link
Contributor

Follows the previously set pattern of colocating styles along side the
consuming components. This one was really straight forward and just a
reorganization of files and imports. No code changes occurred.

@brad-decker brad-decker marked this pull request as ready for review August 17, 2020 21:29
@brad-decker brad-decker requested a review from a team as a code owner August 17, 2020 21:29
@brad-decker brad-decker requested a review from Gudahtt August 17, 2020 21:29
@metamaskbot
Copy link
Collaborator

Builds ready [d0c53a8]
Page Load Metrics (613 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint308142136
domContentLoaded29273561110752
load29473761310752
domInteractive29273561110752

Follows the previously set pattern of colocating styles along side the
consuming components. This one was really straight forward and just a
reorganization of files and imports. No code changes occurred.
@brad-decker brad-decker force-pushed the colocate-confirm-decrypt-message branch from d0c53a8 to 1738997 Compare August 18, 2020 15:49
@metamaskbot
Copy link
Collaborator

Builds ready [1738997]
Page Load Metrics (600 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29453542
domContentLoaded3277465999747
load3287486009747
domInteractive3267465999747

@brad-decker brad-decker merged commit 8b0a308 into develop Aug 18, 2020
@brad-decker brad-decker deleted the colocate-confirm-decrypt-message branch August 18, 2020 19:44
Gudahtt added a commit that referenced this pull request Aug 19, 2020
* origin/develop: (137 commits)
  Use @metamask/eslint-config@3.1.0 (#9275)
  Standardize scss import practices (#9183)
  Update ESLint shared config to v3 (#9274)
  Add lock icon to default networks (#9269)
  Adds toPrecisionWithoutTrailingZeros utility (#9270)
  Hide gas estimate on non-main network (#9189)
  Move the mascot component to its own directory (#9272)
  Use @metamask/controllers@2.0.5 (#9266)
  Fix padding, alignment of actionable-message; add left aligned story
  Code cleanup and simplification for actionable-message component
  Adds actionable message component and stories
  Fix lint issues (#9265)
  Fix prefer-destructuring issues (#9263)
  colocate confirm-decrypt-message page styles (#9252)
  Tidy up Migrator tests (#9264)
  Adds pulse loader component (#9259)
  Fix import/order issues (#9239)
  Fix radix issues (#9247)
  New info tooltip component (#9180)
  Improve scss naming
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants