chore: bump @metamask/smart-transactions-controller to ^19.2.0 (#20152)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bumping `@metamask/smart-transactions-controller`:

```markdown
## [19.2.0]

### Added

- Add missing constants and helpers exports ([#538](MetaMask/smart-transactions-controller#538))
  - `MetaMetricsEventCategory`
  - `MetaMetricsEventName`
  - `getSmartTransactionMetricsProperties`
  - `getSmartTransactionMetricsSensitiveProperties`

## [19.1.0]

### Added

- Add missing exports for types ([#537](MetaMask/smart-transactions-controller#537))
  - `Fee`
  - `Fees`
  - `IndividualTxFees`
  - `FeatureFlags`
  - `SmartTransactionMinedTx`
  - `SmartTransaction`
  - `SmartTransactionCancellationReason`
  - `SmartTransactionStatuses`
  - `ClientId`

## [19.0.0]

### Added

- This package can now be used in ESM environments as well as CommonJS ([#469](MetaMask/smart-transactions-controller#469))
- Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](MetaMask/smart-transactions-controller#531))

### Changed

- **BREAKING:** Disallow subpath exports ([#469](MetaMask/smart-transactions-controller#469))
- **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](MetaMask/smart-transactions-controller#532), [#534](MetaMask/smart-transactions-controller#534))
- **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](MetaMask/smart-transactions-controller#534))
  - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist:
    - `TransactionController:getNonceLock`
    - `TransactionController:confirmExternalTransaction`
    - `TransactionController:getTransactions`
    - `TransactionController:updateTransaction`
- Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](MetaMask/smart-transactions-controller#529))
- Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](MetaMask/smart-transactions-controller#529))

### Removed

- **BREAKING:** Remove default export ([#535](MetaMask/smart-transactions-controller#535))
  - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead.
```

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Upgrades Smart Transactions to ^19.2.1 and Transaction Controller to
^60.4.0, replaces subpath/type imports, migrates Engine/messaging
integration, and updates related hooks, views, selectors, and tests.
> 
> - **Dependencies**:
> - Bump `@metamask/smart-transactions-controller` to `^19.2.1` and
`@metamask/transaction-controller` to `^60.4.0` (lockfile updated).
> - **Engine/Controllers**:
> - Switch to named exports from
`@metamask/smart-transactions-controller`; remove default export usage.
> - Migrate STX controller constructor to use messenger actions
(`TransactionController:getNonceLock`, `confirmExternalTransaction`,
`getTransactions`, `updateTransaction`) instead of direct callbacks; add
MetaMetrics constants/util imports from root.
> - Transaction Controller init: use `SmartTransactionStatuses` from
root; wire STX hooks (single/batch) and metrics/notification handlers;
keep pending resubmit disabled.
> - **App code updates**:
> - Replace all `@metamask/smart-transactions-controller/dist/...`
imports with root package exports (types, enums like `SmartTransaction`,
`SmartTransactionStatuses`, `Fee/Fees`).
> - Update Swaps (QuotesView, useSwapsSmartTransaction),
UnifiedTransactionsView, SmartTransactionStatus components/tests,
NotificationsManager, selectors, migrations, and smart-transactions
utils/hooks to new exports.
> - **Tests**:
> - Adapt tests to new controller exports and messenger permissions for
STX hooks; minor Hex import fixes.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
3c62faf. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Author: 2 people

app/components/UI/Earn/components/Earnings/EarningsHistory/EarningsHistory.test.tsx

@@ -1,12 +1,12 @@
 import React from 'react';
+import { Hex } from '@metamask/utils';
 import { fireEvent } from '@testing-library/react-native';
 import StakingEarningsHistory from './EarningsHistory';
 import useEarningsHistory from '../../../hooks/useEarningsHistory';
 
 import renderWithProvider from '../../../../../../util/test/renderWithProvider';
 import { MOCK_ACCOUNTS_CONTROLLER_STATE } from '../../../../../../util/test/accountsControllerTestUtils';
 import { backgroundState } from '../../../../../../util/test/initial-root-state';
-import { Hex } from '@metamask/smart-transactions-controller/dist/types';
 import { TokenI } from '../../../../Tokens/types';
 import { MOCK_STAKED_ETH_MAINNET_ASSET } from '../../../../Stake/__mocks__/stakeMockData';
 

app/components/UI/Swaps/QuotesView.js

@@ -129,7 +129,7 @@ import SmartTransactionsMigrationBanner from '../../Views/confirmations/legacy/c
 import { useSwapsSmartTransaction } from './utils/useSwapsSmartTransaction';
 import Routes from '../../../constants/navigation/Routes';
 import { ApprovalTypes } from '../../../core/RPCMethods/RPCMethodMiddleware';
-import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller/dist/types';
+import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller';
 import { getTradeTxTokenFee } from '../../../util/smart-transactions';
 import { useFiatConversionRates } from './utils/useFiatConversionRates';
 import { useGasTokenFiatAmount } from './utils/useGasTokenFiatAmount';

app/components/UI/Swaps/utils/useSwapsSmartTransaction.ts

@@ -15,7 +15,7 @@ import { getGasFeeEstimatesForTransaction } from './gas';
 import { Hex } from '@metamask/utils';
 import { ORIGIN_METAMASK } from '@metamask/controller-utils';
 import Logger from '../../../../util/Logger';
-import { Fee } from '@metamask/smart-transactions-controller/dist/types';
+import { Fee } from '@metamask/smart-transactions-controller';
 import {
   getGasIncludedTransactionFees,
   type GasIncludedQuote,

app/components/Views/UnifiedTransactionsView/UnifiedTransactionsView.tsx

@@ -1,6 +1,6 @@
 import { Transaction as NonEvmTransaction } from '@metamask/keyring-api';
 import { SupportedCaipChainId } from '@metamask/multichain-network-controller';
-import { SmartTransaction } from '@metamask/smart-transactions-controller/dist/types';
+import { SmartTransaction } from '@metamask/smart-transactions-controller';
 import { CHAIN_IDS, TransactionMeta } from '@metamask/transaction-controller';
 import { Hex } from '@metamask/utils';
 import { NavigationProp, useNavigation } from '@react-navigation/native';

app/components/Views/transactions/SmartTransactionStatus/SmartTransactionStatus.test.tsx

@@ -8,7 +8,7 @@ import { backgroundState } from '../../../../util/test/initial-root-state';
 import { strings } from '../../../../../locales/i18n';
 import Routes from '../../../../constants/navigation/Routes';
 import { fireEvent } from '@testing-library/react-native';
-import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller/dist/types';
+import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller';
 import { merge } from 'lodash';
 
 const initialState = {

app/components/Views/transactions/SmartTransactionStatus/SmartTransactionStatus.tsx

@@ -1,5 +1,6 @@
 import React, { useMemo } from 'react';
 import { View, Text, StyleSheet, TouchableOpacity } from 'react-native';
+import { Hex } from '@metamask/utils';
 import { strings } from '../../../../../locales/i18n';
 import Icon, {
   IconColor,
@@ -9,10 +10,9 @@ import Icon, {
 import ProgressBar from './ProgressBar';
 import { useTheme } from '../../../../util/theme';
 import {
-  Hex,
   SmartTransaction,
   SmartTransactionStatuses,
-} from '@metamask/smart-transactions-controller/dist/types';
+} from '@metamask/smart-transactions-controller';
 import { useSelector } from 'react-redux';
 import { selectEvmChainId } from '../../../../selectors/networkController';
 import { useNavigation } from '@react-navigation/native';

app/core/Engine/Engine.ts

@@ -92,11 +92,17 @@ import {
   networkIdUpdated,
   networkIdWillUpdate,
 } from '../../core/redux/slices/inpageProvider';
-import SmartTransactionsController from '@metamask/smart-transactions-controller';
+import {
+  SmartTransactionsController,
+  ClientId,
+  MetaMetricsEventName,
+  MetaMetricsEventCategory,
+  getSmartTransactionMetricsProperties as getSmartTransactionMetricsPropertiesType,
+  getSmartTransactionMetricsSensitiveProperties as getSmartTransactionMetricsSensitivePropertiesType,
+} from '@metamask/smart-transactions-controller';
 import { getAllowedSmartTransactionsChainIds } from '../../../app/constants/smartTransactions';
 import { selectBasicFunctionalityEnabled } from '../../selectors/settings';
 import { selectSwapsChainFeatureFlags } from '../../reducers/swaps';
-import { ClientId } from '@metamask/smart-transactions-controller/dist/types';
 import { zeroAddress } from 'ethereumjs-util';
 import {
   type TraceCallback,
@@ -105,14 +111,6 @@ import {
   ///: END:ONLY_INCLUDE_IF
 } from '@metamask/controller-utils';
 import { ExtendedControllerMessenger } from '../ExtendedControllerMessenger';
-import {
-  MetaMetricsEventCategory,
-  MetaMetricsEventName,
-} from '@metamask/smart-transactions-controller/dist/constants';
-import {
-  getSmartTransactionMetricsProperties as getSmartTransactionMetricsPropertiesType,
-  getSmartTransactionMetricsSensitiveProperties as getSmartTransactionMetricsSensitivePropertiesType,
-} from '@metamask/smart-transactions-controller/dist/utils';
 ///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
 import { removeAccountsFromPermissions } from '../Permissions';
 import { multichainBalancesControllerInit } from './controllers/multichain-balances-controller/multichain-balances-controller-init';
@@ -335,25 +333,20 @@ export class Engine {
       // @ts-expect-error TODO: resolve types
       supportedChainIds: getAllowedSmartTransactionsChainIds(),
       clientId: ClientId.Mobile,
-      getNonceLock: (...args) =>
-        this.transactionController.getNonceLock(...args),
-      confirmExternalTransaction: (...args) =>
-        this.transactionController.confirmExternalTransaction(...args),
       trackMetaMetricsEvent: smartTransactionsControllerTrackMetaMetricsEvent,
       state: initialState.SmartTransactionsController,
-      // @ts-expect-error TODO: Resolve mismatch between base-controller versions.
       messenger: this.controllerMessenger.getRestricted({
         name: 'SmartTransactionsController',
         allowedActions: [
           'NetworkController:getNetworkClientById',
           'NetworkController:getState',
+          'TransactionController:getNonceLock',
+          `TransactionController:confirmExternalTransaction`,
+          `TransactionController:getTransactions`,
+          `TransactionController:updateTransaction`,
         ],
         allowedEvents: ['NetworkController:stateChange'],
       }),
-      getTransactions: (...args) =>
-        this.transactionController.getTransactions(...args),
-      updateTransaction: (...args) =>
-        this.transactionController.updateTransaction(...args),
       getFeatureFlags: () => selectSwapsChainFeatureFlags(store.getState()),
       getMetaMetricsProps: () => Promise.resolve({}), // Return MetaMetrics props once we enable HW wallets for smart transactions.
       trace: trace as TraceCallback,

app/core/Engine/controllers/transaction-controller/transaction-controller-init.test.ts

@@ -7,7 +7,7 @@ import {
   TransactionType,
   type PublishBatchHookTransaction,
 } from '@metamask/transaction-controller';
-import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller/dist/types';
+import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller';
 import { NetworkController } from '@metamask/network-controller';
 
 import { selectSwapsChainFeatureFlags } from '../../../../reducers/swaps';

app/core/Engine/controllers/transaction-controller/transaction-controller-init.ts

@@ -7,11 +7,13 @@ import {
   type PublishBatchHookTransaction,
   type PublishBatchHookResult,
 } from '@metamask/transaction-controller';
-import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller/dist/types';
 import { Hex } from '@metamask/utils';
 import { ApprovalController } from '@metamask/approval-controller';
 import { PreferencesController } from '@metamask/preferences-controller';
-import SmartTransactionsController from '@metamask/smart-transactions-controller';
+import {
+  SmartTransactionsController,
+  SmartTransactionStatuses,
+} from '@metamask/smart-transactions-controller';
 
 import { REDESIGNED_TRANSACTION_TYPES } from '../../../../components/Views/confirmations/constants/confirmations';
 import { selectSwapsChainFeatureFlags } from '../../../../reducers/swaps';

app/core/Engine/controllers/transaction-controller/types.ts

@@ -1,5 +1,5 @@
 import { JsonMap } from '../../../Analytics/MetaMetrics.types';
-import SmartTransactionsController from '@metamask/smart-transactions-controller';
+import { SmartTransactionsController } from '@metamask/smart-transactions-controller';
 import type { RootState } from '../../../../reducers';
 import { TransactionControllerInitMessenger } from '../../messengers/transaction-controller-messenger';
 import { TransactionMeta } from '@metamask/transaction-controller';