Fix Android paste #469

estebanmino · 2019-03-06T19:18:25Z

Description

Some inputs in android were not triggering the paste option as explained in MetaMask/website#465. A workaround was implemented while the problem is fixed from react-native.

Checklist

There is a related GitHub issue
Tests are included if applicable
Any added code is fully documented

Issue

Resolves #465

brunobar79

LGTM! just one single comment for all the ocurrences, while setting state inside a timeout, make sure the component is still mounted by doing this.mounted && this.setState... otherwise it will trigger a warning

You also need to set this.mounted = true in componentDidMount and set it to false in componentWillUnmount

brunobar79 · 2019-03-06T20:22:52Z

app/components/UI/AddCustomCollectible/index.js

+		// Workaround https://github.com/facebook/react-native/issues/9958
+		this.state.inputWidth &&
+			setTimeout(() => {
+				this.setState({ inputWidth: '100%' });


this.mounted &&

brunobar79 · 2019-03-06T20:23:02Z

app/components/UI/HomePage/index.js

+		// Workaround https://github.com/facebook/react-native/issues/9958
+		this.state.inputWidth &&
+			setTimeout(() => {
+				this.setState({ inputWidth: '100%' });


brunobar79 · 2019-03-06T20:23:13Z

app/components/Views/AdvancedSettings/index.js

+		// Workaround https://github.com/facebook/react-native/issues/9958
+		this.state.inputWidth &&
+			setTimeout(() => {
+				this.setState({ inputWidth: '100%' });


brunobar79 · 2019-03-06T20:23:19Z

app/components/Views/ImportFromSeed/index.js

+		// Workaround https://github.com/facebook/react-native/issues/9958
+		this.state.inputWidth &&
+			setTimeout(() => {
+				this.setState({ inputWidth: '100%' });


brunobar79 · 2019-03-06T20:23:26Z

app/components/Views/ImportPrivateKey/index.js

+		// Workaround https://github.com/facebook/react-native/issues/9958
+		this.state.inputWidth &&
+			setTimeout(() => {
+				this.setState({ inputWidth: '100%' });


estebanmino · 2019-03-06T21:22:43Z

@brunobar79 done

brunobar79 · 2019-03-07T03:12:14Z

app/components/UI/HomePage/index.js

 		marginHorizontal: 10,
 		backgroundColor: colors.white,
 		fontSize: 14,
-		flex: 1,


@estebanmino This broke iOS

* fix android paste * snapshot * email-address * auto complete off * snapshots * mounted

…20152)  ## **Description**  Bumping `@metamask/smart-transactions-controller`: ```markdown ## [19.2.0] ### Added - Add missing constants and helpers exports ([#538](MetaMask/smart-transactions-controller#538)) - `MetaMetricsEventCategory` - `MetaMetricsEventName` - `getSmartTransactionMetricsProperties` - `getSmartTransactionMetricsSensitiveProperties` ## [19.1.0] ### Added - Add missing exports for types ([#537](MetaMask/smart-transactions-controller#537)) - `Fee` - `Fees` - `IndividualTxFees` - `FeatureFlags` - `SmartTransactionMinedTx` - `SmartTransaction` - `SmartTransactionCancellationReason` - `SmartTransactionStatuses` - `ClientId` ## [19.0.0] ### Added - This package can now be used in ESM environments as well as CommonJS ([#469](MetaMask/smart-transactions-controller#469)) - Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](MetaMask/smart-transactions-controller#531)) ### Changed - **BREAKING:** Disallow subpath exports ([#469](MetaMask/smart-transactions-controller#469)) - **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](MetaMask/smart-transactions-controller#532), [#534](MetaMask/smart-transactions-controller#534)) - **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](MetaMask/smart-transactions-controller#534)) - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist: - `TransactionController:getNonceLock` - `TransactionController:confirmExternalTransaction` - `TransactionController:getTransactions` - `TransactionController:updateTransaction` - Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](MetaMask/smart-transactions-controller#529)) - Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](MetaMask/smart-transactions-controller#529)) ### Removed - **BREAKING:** Remove default export ([#535](MetaMask/smart-transactions-controller#535)) - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead. ``` ## **Changelog**  CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.  --- > [!NOTE] > Upgrades Smart Transactions to ^19.2.1 and Transaction Controller to ^60.4.0, replaces subpath/type imports, migrates Engine/messaging integration, and updates related hooks, views, selectors, and tests. > > - **Dependencies**: > - Bump `@metamask/smart-transactions-controller` to `^19.2.1` and `@metamask/transaction-controller` to `^60.4.0` (lockfile updated). > - **Engine/Controllers**: > - Switch to named exports from `@metamask/smart-transactions-controller`; remove default export usage. > - Migrate STX controller constructor to use messenger actions (`TransactionController:getNonceLock`, `confirmExternalTransaction`, `getTransactions`, `updateTransaction`) instead of direct callbacks; add MetaMetrics constants/util imports from root. > - Transaction Controller init: use `SmartTransactionStatuses` from root; wire STX hooks (single/batch) and metrics/notification handlers; keep pending resubmit disabled. > - **App code updates**: > - Replace all `@metamask/smart-transactions-controller/dist/...` imports with root package exports (types, enums like `SmartTransaction`, `SmartTransactionStatuses`, `Fee/Fees`). > - Update Swaps (QuotesView, useSwapsSmartTransaction), UnifiedTransactionsView, SmartTransactionStatus components/tests, NotificationsManager, selectors, migrations, and smart-transactions utils/hooks to new exports. > - **Tests**: > - Adapt tests to new controller exports and messenger permissions for STX hooks; minor Hex import fixes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3c62faf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>  --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>

estebanmino added 2 commits March 6, 2019 16:13

fix android paste

548ea34

snapshot

bfe6f05

estebanmino requested review from bitpshr and brunobar79 March 6, 2019 19:18

estebanmino added 5 commits March 6, 2019 16:37

Merge branch 'develop' into fix-android-paste

0458811

email-address

3808ef1

merge

bf4e205

auto complete off

b15fda2

snapshots

c0bb375

brunobar79 approved these changes Mar 6, 2019

View reviewed changes

Bruno Barbieri and others added 3 commits March 6, 2019 16:07

Merge branch 'develop' into fix-android-paste

0f0de25

mounted

0715653

merge

0087a83

Merge branch 'develop' into fix-android-paste

d9083b7

estebanmino merged commit 04dbc10 into develop Mar 6, 2019

estebanmino deleted the fix-android-paste branch March 6, 2019 21:46

brunobar79 reviewed Mar 7, 2019

View reviewed changes

rickycodes pushed a commit that referenced this pull request Jan 31, 2022

Fix Android paste (#469)

979da60

* fix android paste * snapshot * email-address * auto complete off * snapshots * mounted

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix Android paste #469

Fix Android paste #469

Uh oh!

estebanmino commented Mar 6, 2019 •

edited

Loading

Uh oh!

brunobar79 left a comment

Uh oh!

brunobar79 Mar 6, 2019

Uh oh!

brunobar79 Mar 6, 2019

Uh oh!

brunobar79 Mar 6, 2019

Uh oh!

brunobar79 Mar 6, 2019

Uh oh!

brunobar79 Mar 6, 2019

Uh oh!

estebanmino commented Mar 6, 2019

Uh oh!

brunobar79 Mar 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Fix Android paste #469

Fix Android paste #469

Uh oh!

Conversation

estebanmino commented Mar 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunobar79 left a comment

Choose a reason for hiding this comment

Uh oh!

brunobar79 Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

brunobar79 Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

brunobar79 Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

brunobar79 Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

brunobar79 Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

estebanmino commented Mar 6, 2019

Uh oh!

brunobar79 Mar 7, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

estebanmino commented Mar 6, 2019 •

edited

Loading