Enable back button if going from dapp to home #1408
Assignees
Comments
|
see Trello for design |
|
Found other issues with the navigation while fixing this issue. Going back from a dapp and then trying to go forward, it takes you back to home. Also, The back button is available but it does not do anything: Inside the dapp, there seems to be other issues as well, for example, back button only works after 3 attempts (could be a problem with the dapp itself, but it seems to happen with others as well): |
omnat
added
the
needs-qa
MarioAslau
added a commit
that referenced
this issue
Feb 26, 2024
## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Currently on iOS when the user is promted with an alert to grant permissions for a website that has a big domain, it will hide the entire Alert message that the website is requesting. ## **Related issues** MetaMask/mobile-planning#1408 Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **e2e Testing** https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/abb68302-f423-4084-9cd5-3fef3a0a5c7c ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> Before: <img src="https://github.com/MetaMask/mobile-planning/assets/46944231/240bb1b8-78f3-41b3-8378-566ca7de4bc8" width=250 /> This is the website we can use for debugging purposes: https://nfttoks.crypto.comsssssssss.go.f-secure.com.egghunter.in/camera.html After: <img width="403" alt="Screenshot 2024-02-02 at 16 10 13" src="https://github.com/MetaMask/metamask-mobile/assets/15312578/384d2531-a113-4909-9ded-8494b840f811"> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Cal Leung <cleun007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I'm on a dapp and I tap the home button, I am unable to go back to the dapp I was previously on. Let's enable the back button if the user was previously on a dapp.
The text was updated successfully, but these errors were encountered: