Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize deep linking on the simulator/emulator for E2E #5536

Closed
cortisiko opened this issue Jan 17, 2023 · 5 comments · Fixed by #7841
Closed

Stabilize deep linking on the simulator/emulator for E2E #5536

cortisiko opened this issue Jan 17, 2023 · 5 comments · Fixed by #7841
Assignees
@tommasini
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform team-sdk SDK team

Comments

@cortisiko
Copy link
Member

I am experiencing an issue when trying to deep link on the simulator. I can successfully deep link to a dapp or to a particular transaction the first couple of times. Afterward, it is impossible to actually deep link.

For example, I would attempt to deep link here: https://metamask.app.link/dapp/metamask.github.io/test-dapp/

the app launches but I am not taken to the mm test dapp in the browser view. See the recording here.

This is breaking the e2e deep linking tests. I can confirm that this DOES NOT happen on physical devices

See my original slack message here: https://consensys.slack.com/archives/C02U025CVU4/p1671222774797949

To reproduce on your simulator/emulator:

  • launch the app in the simulator
  • attempt to deep link to any of the universal deep links here
  • close and relaunch the app and attempt to deep link a few more times. After a while the app stops deep linking.

Just an FYI: Wiping the device each time works but this does not make sense for E2E testing.
@tommasini tommasini self-assigned this Jan 17, 2023
@tommasini
Copy link
Contributor

tommasini commented Jan 18, 2023 •
edited
Loading

Update: This happens to me on my Physical Android device on MM version 5.12.1, downloaded from the store

@tommasini tommasini mentioned this issue Jan 18, 2023
Closed
3 tasks
@tommasini
Copy link
Contributor

tommasini commented Jan 19, 2023 •
edited
Loading

The PR created #5543, doesn't solve this particular issue of universal links, I will move this issue to the backlog until we have enough resources to move forward
I think it's a known issue and will attach some threads/articles below to justify it:

@andreahaku andreahaku mentioned this issue Mar 9, 2023
Closed
3 tasks
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Apr 20, 2023
@cortisiko cortisiko removed the stale Issues that have not had activity in the last 90 days label Apr 24, 2023
@sethkfman sethkfman added the team-sdk SDK team label May 23, 2023
@hesterbruikman
Copy link
Contributor

@andreahaku do you remember why this PR was closed? Did it not address the issue?

@andreahaku
Copy link
Contributor

@andreahaku do you remember why this PR was closed? Did it not address the issue?

I did not close it. I thinks it's been closed for inactivity. There is still no solution to it unfortunately.

@andreahaku andreahaku mentioned this issue Nov 16, 2023
Merged
13 tasks
christopherferreira9 pushed a commit that referenced this issue Nov 16, 2023
@abretonc7s
fix: branch io deeplink stop on error without handling link (#7841)
65754d5 
## **Description**

Deeplinks were skipped when branch io subscription contains an error but
that shouldn't prevent handling the current link.
Instead we log the error and continue to process the deeplink which is
especially important for SDK connection which would otherwise be
ignored.

## **Related issues**

Fixes: #5536 

## **Manual testing steps**

On IOS you would normally have to build the app twice to process
deeplinks with branch io.

1. Retrieve universal link while building the app only once on Ios
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommasini tommasini

Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform team-sdk SDK team
Projects
None yet
Milestone
No milestone
7 participants
@gauthierpetetin @andreahaku @sethkfman @cortisiko @hesterbruikman @metamaskbot @tommasini