Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: branch io deeplink stop on error without handling link #7841

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: branch io deeplink stop on error without handling link #7841

merged 1 commit into from
Nov 16, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Nov 16, 2023 •
edited
Loading

Description

Deeplinks were skipped when branch io subscription contains an error but that shouldn't prevent handling the current link.
Instead we log the error and continue to process the deeplink which is especially important for SDK connection which would otherwise be ignored.

Related issues

Fixes: #5536

Manual testing steps

On IOS you would normally have to build the app twice to process deeplinks with branch io.

  1. Retrieve universal link while building the app only once on Ios

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team labels Nov 16, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

andreahaku
andreahaku approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Code Impact - Low Minor code change that can safely applied to the codebase Priority - Medium Task with medium priority release-7.12.0 Issue or pull request that will be included in release 7.12.0 needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 16, 2023
@abretonc7s abretonc7s marked this pull request as ready for review November 16, 2023 10:22
@abretonc7s abretonc7s requested a review from a team as a code owner November 16, 2023 10:22
@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/abd97337-3721-4737-a51a-93b44bf49423
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 16, 2023
@christopherferreira9
Copy link
Contributor

The first time build issue still persists unless metro fully loads. Once it does it works perfectly without having to build again.
Will do a sanity check of multiple dapps and later check if it fixes #5536

@christopherferreira9
Copy link
Contributor

LGTM

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Nov 16, 2023
@christopherferreira9 christopherferreira9 merged commit 65754d5 into main Nov 16, 2023
74 of 84 checks passed
@christopherferreira9 christopherferreira9 deleted the fix/branchio-init branch November 16, 2023 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
Code Impact - Low Minor code change that can safely applied to the codebase Priority - Medium Task with medium priority QA Passed A successful QA run through has been done release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize deep linking on the simulator/emulator for E2E
3 participants
@abretonc7s @christopherferreira9 @andreahaku