Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @metamask/keyring-controller from v6 to v7 #8180

Closed
2 of 9 tasks
gantunesr opened this issue Dec 21, 2023 · 0 comments · Fixed by #8035
Closed
2 of 9 tasks

Bump @metamask/keyring-controller from v6 to v7 #8180

gantunesr opened this issue Dec 21, 2023 · 0 comments · Fixed by #8035
Assignees
@gantunesr
Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-accounts

Comments

@gantunesr
Copy link
Member

What is this about?

Bump @metamask/keyring-controller from v6 to v7

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@gantunesr gantunesr self-assigned this Dec 21, 2023
@gantunesr gantunesr mentioned this issue Dec 21, 2023
Merged
13 tasks
plasmacorral pushed a commit that referenced this issue Jan 6, 2024
@gantunesr
feat: bump keyring controller 7.5.0 (#8035)
445ef2b 
## **Description**


This PR bumps the `@metamask/keyring-controller` version from `6.0.0` to
`7.5.0`. These are the relevant changes to take into consideration
during review,

- **BREAKING**: Remove `keyringTypes` property from the
KeyringController state
([#1441](MetaMask/core#1441))
- **BREAKING**: Constructor `KeyringControllerOptions` type changed
([#1441](MetaMask/core#1441))
- The `KeyringControllerOptions.state` accepted type is now `{ vault?:
string }`
- The `KeyringControllerOptions.keyringBuilders` type is now `{ ():
Keyring<Json>; type: string }[]`
- **BREAKING**: The `address` type accepted by the `removeAccount`
method is now `Hex`
([#1441](MetaMask/core#1441))
- **BREAKING**: The `signTypedMessage` method now returns a
`Promise<string>` ([#1441](MetaMask/core#1441))
- **BREAKING**: The `signTransaction` method now requires a
`TypedTransaction` from `@ethereumjs/tx@^4` for the `transaction`
argument, and returns a `Promise<TxData>`
([#1441](MetaMask/core#1441))
- **BREAKING:** Rename `Keyring` type to `KeyringObject`
([#1441](MetaMask/core#1441))
- **BREAKING:** `addNewAccount` now throws if address of new account is
not a hex string ([#1441](MetaMask/core#1441))
- **BREAKING:** `exportSeedPhrase` now throws if first keyring does not
have a mnemonic ([#1441](MetaMask/core#1441))
- **BREAKING:** `verifySeedPhrase` now throws if HD keyring does not
have a mnemonic ([#1441](MetaMask/core#1441))
 

## **Related issues**

Fixes: #8180

## **Manual testing steps**

Use cases or flows to verify,

1. Onboarding
2. Import SRP
3. Import private key
4. Reveal SRP
5. Reveal private key
6. Add new account
7. Connect QR wallet
8. Signed type messages
9. Remove imported account
10. Lock and unlock wallet

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [X ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [X ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.15.0 Issue or pull request that will be included in release 7.15.0 label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gantunesr gantunesr

Labels
release-7.15.0 Issue or pull request that will be included in release 7.15.0 team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: bump keyring controller 7.5.0 MetaMask/metamask-mobile
2 participants
@gantunesr @metamaskbot