Detox: Address Book Tests #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
changed the title
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* start flow of address book * make addressbook great again
plasmacorral
pushed a commit
that referenced
this pull request
Jan 6, 2024
## **Description** This PR bumps the `@metamask/keyring-controller` version from `6.0.0` to `7.5.0`. These are the relevant changes to take into consideration during review, - **BREAKING**: Remove `keyringTypes` property from the KeyringController state ([#1441](MetaMask/core#1441)) - **BREAKING**: Constructor `KeyringControllerOptions` type changed ([#1441](MetaMask/core#1441)) - The `KeyringControllerOptions.state` accepted type is now `{ vault?: string }` - The `KeyringControllerOptions.keyringBuilders` type is now `{ (): Keyring<Json>; type: string }[]` - **BREAKING**: The `address` type accepted by the `removeAccount` method is now `Hex` ([#1441](MetaMask/core#1441)) - **BREAKING**: The `signTypedMessage` method now returns a `Promise<string>` ([#1441](MetaMask/core#1441)) - **BREAKING**: The `signTransaction` method now requires a `TypedTransaction` from `@ethereumjs/tx@^4` for the `transaction` argument, and returns a `Promise<TxData>` ([#1441](MetaMask/core#1441)) - **BREAKING:** Rename `Keyring` type to `KeyringObject` ([#1441](MetaMask/core#1441)) - **BREAKING:** `addNewAccount` now throws if address of new account is not a hex string ([#1441](MetaMask/core#1441)) - **BREAKING:** `exportSeedPhrase` now throws if first keyring does not have a mnemonic ([#1441](MetaMask/core#1441)) - **BREAKING:** `verifySeedPhrase` now throws if HD keyring does not have a mnemonic ([#1441](MetaMask/core#1441)) ## **Related issues** Fixes: #8180 ## **Manual testing steps** Use cases or flows to verify, 1. Onboarding 2. Import SRP 3. Import private key 4. Reveal SRP 5. Reveal private key 6. Add new account 7. Connect QR wallet 8. Signed type messages 9. Remove imported account 10. Lock and unlock wallet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [X ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [X ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains e2e tests for our address book feature
Flow seen here = https://recordit.co/RVjwGoIXT4