-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable wallet buttons for accounts that cannot sign transactions #11330
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 0f8068e Note
Tip
|
Bitrise✅✅✅ Commit hash: ed95ed3 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, left some minor comments
@@ -1237,6 +1238,14 @@ | |||
"info": "Info", | |||
"swap": "Swap", | |||
"bridge": "Bridge", | |||
"disabled_button": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexJupiter @eriknson what do you think of this copy?
2613b17
to
7a0a91a
Compare
Bitrise❌❌❌ Commit hash: f5d01a6 Note
Tip
|
app/components/Views/AssetDetails/AssetDetailsActions/AssetDetailsActions.tsx
Outdated
Show resolved
Hide resolved
Bitrise❌❌❌ Commit hash: abda0b1 Note
Tip
|
d958792
to
ab171e4
Compare
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: ab171e4 Note
Tip
|
Having an issue with local builds of flask on this branch in commit ab171e4
Not observed with a flask build of main commit 076fa31 |
Description
This PR disables certain buttons in the
WalletActions
component when the selected account cannot sign transactions. This change improves the user experience by preventing attempts to perform actions that require transaction signing when the account cannot do so.Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/570
Manual testing steps
eth_signTransaction
from the account's methods)Screenshots/Recordings
Before
Wallet view
Asset details view
After
Wallet view
Asset details view
Pre-merge author checklist
Pre-merge reviewer checklist