Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable wallet buttons for accounts that cannot sign transactions #11330

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat: disable wallet buttons for accounts that cannot sign transactions #11330

wants to merge 23 commits into from
+431 −135

Commits on Oct 18, 2024

  1. parent fb86c83 

    author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215624 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215619 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215615 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215606 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215597 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215562 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215557 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215549 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215524 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215487 -0400

parent fb86c83
author Matthew Grainger <46547583+Matt561@users.noreply.github.com> 1727214167 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215477 -0400

feat: added KeyValueRow to component-library/components-temp

parent cc011ce43e59ae70cb239408c8f0f6de10772def
author Kate Johnson <johnson.kat.g@gmail.com> 1726779250 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215830 -0400

parent cc011ce43e59ae70cb239408c8f0f6de10772def
author Kate Johnson <johnson.kat.g@gmail.com> 1726779250 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215818 -0400

parent cc011ce43e59ae70cb239408c8f0f6de10772def
author Kate Johnson <johnson.kat.g@gmail.com> 1726779250 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215815 -0400

parent cc011ce43e59ae70cb239408c8f0f6de10772def
author Kate Johnson <johnson.kat.g@gmail.com> 1726779250 -0400
committer Kate Johnson <johnson.kat.g@gmail.com> 1727215806 -0400

feat: disabled wallet overview buttons for accounts that cannot sign transactions

feat: remove 'should' from test description

Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
    @Matt561 @gantunesr @k-g-j
    2 people authored and k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1a0ac3d View commit details
    Browse the repository at this point in the history

  2. feat: rename 'WalletActionStrings' to 'Details'

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    a2c1fca View commit details
    Browse the repository at this point in the history

  3. feat: moved disabled descriptions into asset_overview

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f311f4b View commit details
    Browse the repository at this point in the history

  4. feat: memoize 'selectedAccount' in WalletActions

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4405795 View commit details
    Browse the repository at this point in the history

  5. feat: memoize 'selectedAccount' in WalletActions and revert changes i… 

    …n ios/MetaMask.xcodeproj/project.pbxproj
    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    703ecd7 View commit details
    Browse the repository at this point in the history

  6. revert: changes in NotificationsManager" 

    "
    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    698c2d4 View commit details
    Browse the repository at this point in the history

  7. feat: made 'actionType' for WalletAction.types non-optional

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e536653 View commit details
    Browse the repository at this point in the history

  8. chore: update snapshots

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c9d0159 View commit details
    Browse the repository at this point in the history

  9. feat: update AssetDetailsActions.test to use IDs for buttons

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2809632 View commit details
    Browse the repository at this point in the history

  10. feat: updated computed styles in AssetDetailsActions, WalletActions, … 

    …and WalletAction
    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9b9470a View commit details
    Browse the repository at this point in the history

  11. feat: remove render function from AssetDetailsActions

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e82786b View commit details
    Browse the repository at this point in the history

  12. feat: undo changes in ios/MetaMask.xcodeproj/project.pbxproj

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e56b156 View commit details
    Browse the repository at this point in the history

  13. feat: made 'actionType' optional prop

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7d62792 View commit details
    Browse the repository at this point in the history

  14. chore: update snapshots

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    64ed760 View commit details
    Browse the repository at this point in the history

  15. fix: app/components/Views/AssetDetails/AssetDetailsActions/AssetDetai… 

    …lsActions.test.tsx
    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    267e93f View commit details
    Browse the repository at this point in the history

  16. feat: disabled buttons in AssetDetails view

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7a2b2e1 View commit details
    Browse the repository at this point in the history

  17. feat: removed string function from label rendering and removed label … 

    …from account overview
    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7203cec View commit details
    Browse the repository at this point in the history

  18. chore: strings cleanup

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    daf1c05 View commit details
    Browse the repository at this point in the history

  19. Revert "chore: strings cleanup" 

    This reverts commit 981884a.
    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    90d2e51 View commit details
    Browse the repository at this point in the history

  20. Revert "feat: removed string function from label rendering and remove… 

    …d label from account overview"

This reverts commit 54ac028.
    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    29bdaea View commit details
    Browse the repository at this point in the history

  21. feat: fix merge conflicts with accounts controller selectors

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    51a91b3 View commit details
    Browse the repository at this point in the history

  22. chore: rebase with main

    @k-g-j
    k-g-j committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ab171e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Merge branch 'main' into feat/disable-signing-buttons

    @k-g-j
    k-g-j authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c0b725b View commit details
    Browse the repository at this point in the history